Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger UI doesn't use NC_PUBLIC_URL #288

Closed
dismantl opened this issue Jun 16, 2021 · 3 comments
Closed

Swagger UI doesn't use NC_PUBLIC_URL #288

dismantl opened this issue Jun 16, 2021 · 3 comments
Assignees
@pranavxc
Labels
🐛 Type: Bug Something is broken or incorrect unexpectedly.

Comments

@dismantl
Copy link

Please enter the following details

Node: v12.22.1
Arch: x64
Platform: linux
Docker: true
Database: pg
ProjectOnRootDB: false
RootDB: mysql2
PackageVersion: 0.9.33

Steps To Reproduce

  1. Run NocoDB using Docker, and set the NC_PUBLIC_URL environment variable (e.g. NC_PUBIC_URL=https://nocodb.example.com). Serve the site at that URL using a reverse proxy.
  2. From NocoDB (at the public URL), click avatar > Swagger APIs Doc to open the Swagger UI
  3. Despite being served from the public URL, Swagger shows the base URL as localhost:8080, which causes the endpoints to fail when tested.

Expected behavior
I would expect Swagger to use the public URL to generate the REST endpoints.

Screenshots
image

image
@pranavxc pranavxc added the 🐛 Type: Bug Something is broken or incorrect unexpectedly. label Jun 17, 2021
@pranavxc pranavxc self-assigned this Jun 17, 2021
@JosXa
Copy link

JosXa commented Jul 2, 2021

There is no pull request linked to the closing of this issue. Has it been fixed @pranavxc?

@pranavxc
Copy link
Member

pranavxc commented Jul 2, 2021 •
edited
Loading

@JosXa : it's fixed in the latest version, please try 0.84.7

akbarpasha pushed a commit to akbarpasha/nocodb that referenced this issue Nov 15, 2021
@pranavxc
fix: Generate swagger host and scheme
34fb920 
genarated swagger scheme and host based on `NC_PUBLIC_URL` environment variable

fixes nocodb#288

Signed-off-by: Pranav C Balan <pranavxc@gmail.com>
@JosXa
Copy link

JosXa commented Jan 23, 2022

Ah, that one just isn't on docker hub yet. I'll wait :)

mustafapc19 added a commit that referenced this issue Apr 25, 2023
@mustafapc19
Merge pull request #288 from nocodb/develop-sync
d8d83ea 
Develop sync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranavxc pranavxc

Labels
🐛 Type: Bug Something is broken or incorrect unexpectedly.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dismantl @JosXa @pranavxc