Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - LinkToAnotherRecord related bug fixes #1697

Merged
merged 6 commits into from
Apr 16, 2022
Merged

Fix - LinkToAnotherRecord related bug fixes #1697

merged 6 commits into from
Apr 16, 2022

Conversation

pranavxc
Copy link
Member

Change Summary

Related to #1696 , #1695 , #1693 , #1694

@pranavxc
fix: allow hmList permission for commenter/viewer role
3d9125f 
re #1693

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: allow projectInfoGet permission for commenter/viewer role
5a86140 
re #1694

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: update hasmany record unlink method with new sdk functions
b1fba03 
re #1695

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: save relation column data fro newly created row by using `nested…
3bb41d7 
…Add` method

re #1696

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc requested a review from dstala April 16, 2022 10:14
@pranavxc
refactor: replace nestedDelete with nestedRemove
3c745fc 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: user info api call correction
5b7c120 
Signed-off-by: Pranav C <pranavxc@gmail.com>
dstala
dstala approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@dstala dstala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes verified locally

@dstala dstala merged commit 8c24cf2 into develop Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavxc @dstala