Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - LTAR based filter #1757

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Fix - LTAR based filter #1757

merged 2 commits into from
Apr 19, 2022

Conversation

pranavxc
Copy link
Member

@pranavxc pranavxc commented Apr 19, 2022 •
edited by wingkwong
Loading

Resolved issues

  • Fixed belongs to column-based filter issue
  • Nested record mapping issue when referring to the same table as child/parent.

@pranavxc
fix: refer parent table referenced column in filter query(BT)
be0ab2c 
re #1756

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
fix: wrap nested add update query select part to avoid issue when ref…
19a0eee 
…erencing same table

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc requested a review from wingkwong April 19, 2022 06:42
@pranavxc pranavxc added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Apr 19, 2022
wingkwong
wingkwong approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

@wingkwong wingkwong removed the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Apr 19, 2022
@wingkwong wingkwong merged commit d5aa171 into develop Apr 19, 2022
@wingkwong wingkwong deleted the fix/1756-ltar-based-filter branch July 2, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavxc @wingkwong