Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui-v2): show form items in editable state and handle LTAR columns #3169

Merged
merged 13 commits into from Aug 16, 2022

Conversation

pranavxc
Copy link
Member

@pranavxc pranavxc commented Aug 16, 2022

Change Summary

  • Show form view inputs in an editable state
  • Handle LTAR columns and show cards for has many and many to many.
  • LTAR issues in the grid view
  • Date/Year/Time/Datetime picker bugs

re #3161 , #3164, #3144

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Screenshot 2022-08-16 at 11 31 29 AM

Screenshot 2022-08-16 at 11 31 39 AM

packages/nc-gui-v2/components/smartsheet/Form.vue Outdated Show resolved Hide resolved
packages/nc-gui-v2/components/smartsheet/Form.vue Outdated Show resolved Hide resolved
packages/nc-gui-v2/components/smartsheet/Form.vue Outdated Show resolved Hide resolved
packages/nc-gui-v2/components/smartsheet/Form.vue Outdated Show resolved Hide resolved
Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Filter value should be cleared when the modal is closed
    • Steps to reproduce:
      • Click Link to 'Actor'
      • Search camelot
      • Click CAMELOT VACATION
      • Click Link to 'Actor'
      • Filtered result is shown while filter value is cleared in v1
  2. Deleting a record causes a 404 error.
    image

packages/nc-gui-v2/components/smartsheet/Form.vue Outdated Show resolved Hide resolved
Signed-off-by: Pranav C <pranavxc@gmail.com>
Copy link
Member

@dstala dstala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reduce height of HM column in the form
  • Cell that need picker are still not editable

…w row

Signed-off-by: Pranav C <pranavxc@gmail.com>
Signed-off-by: Pranav C <pranavxc@gmail.com>
… in editable state by default

Signed-off-by: Pranav C <pranavxc@gmail.com>
…ht one

Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc
Copy link
Member Author

  1. Filter value should be cleared when the modal is closed

    • Steps to reproduce:

      • Click Link to 'Actor'
      • Search camelot
      • Click CAMELOT VACATION
      • Click Link to 'Actor'
      • Filtered result is shown while filter value is cleared in v1
  2. Deleting a record causes a 404 error.
    image

Fixed

@pranavxc
Copy link
Member Author

  • Reduce height of HM column in the form
  • Cell that need picker are still not editable

Updated height and fixed cell related issues

Signed-off-by: Pranav C <pranavxc@gmail.com>
@dstala dstala merged commit 73bcb09 into develop Aug 16, 2022
@dstala dstala deleted the fix/3161-form-view-issues branch August 16, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants