Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gui-v2): isLocked #3209

Merged
merged 22 commits into from
Aug 18, 2022
Merged

feat(gui-v2): isLocked #3209

merged 22 commits into from
Aug 18, 2022

Conversation

wingkwong
Copy link
Member

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@wingkwong
feat(gui-v2): provide isLocked in smartsheet
760c3ae
@wingkwong
feat(gui-v2): add disabled nc-menu-item css
bdf41fe
@wingkwong
feat(gui-v2): disable csv in locked view
c966f21
@wingkwong
Merge branch 'develop' into feat/gui-v2-is-locked
ac75a41
@wingkwong
style(gui-v2): add disabled for right toolbar menu item
298308d
@wingkwong
feat(gui-v2): disable add row in form view
41b392f
@wingkwong
chore(gui-v2): use InjectionKey<Ref<boolean>> for IsLockedInj
c7be25e
@wingkwong
feat(gui-v2): disable add column button in a locked view
31153fd
@wingkwong
feat(gui-v2): disable expand form button in a locked view
2e3e8ed
@wingkwong
feat(gui-v2): add isLocked condition on BT, HM and MM cells
7953d65
@wingkwong
style(gui-v2): add nc-locked-overlay
84dd961
@wingkwong
feat(gui-v2): add nc-locked-overlay to cells for lock view
9c891b6
@wingkwong
feat(gui-v2): disable edit & delete column option in locked view
cd45e52
@wingkwong
feat(gui-v2): add isLocked for Treeview
fa64125
@wingkwong
chore(gui-v2): lint
114f79a
@wingkwong
feat(gui-v2): disable copy & delete view in sidebar for locked view
cfe0109
@wingkwong wingkwong requested a review from dstala August 17, 2022 12:22
@wingkwong wingkwong marked this pull request as ready for review August 17, 2022 12:23
dstala
dstala reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@dstala dstala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wingkwong

Screenshot 2022-08-17 at 9 33 27 PM
Screenshot 2022-08-17 at 9 33 33 PM

@wingkwong wingkwong requested a review from dstala August 18, 2022 04:07
@wingkwong
Copy link
Member Author

@dstala updated

@dstala dstala merged commit 40f1cd1 into develop Aug 18, 2022
@dstala dstala deleted the feat/gui-v2-is-locked branch August 18, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstala dstala dstala approved these changes

Assignees

@dstala dstala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wingkwong @dstala