Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gui-v2): handle opening shared view/base opening in same window #3453

Merged
merged 1 commit into from
Sep 2, 2022
Merged

fix(gui-v2): handle opening shared view/base opening in same window #3453

merged 1 commit into from
Sep 2, 2022

Conversation

pranavxc
Copy link
Member

@pranavxc pranavxc commented Sep 2, 2022

Change Summary

re #3388

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Screenshot 2022-09-02 at 9 06 20 PM

Screenshot 2022-09-02 at 9 05 51 PM

@pranavxc
fix(gui-v2): handle opening shared view/base opening in same window
174c9a8 
Signed-off-by: Pranav C <pranavxc@gmail.com>
@pranavxc pranavxc requested a review from dstala September 2, 2022 15:37
@dstala dstala merged commit 0c7cf0a into develop Sep 2, 2022
@dstala dstala deleted the fix/3388-shared-base-open branch September 2, 2022 16:00
@dolsem
Copy link
Contributor

dolsem commented Sep 3, 2022 •
edited
Loading

@pranavxc This PR broke #3374. Is there a way to reconcile it? Why is setting super to '*' breaks permissions for lower level users?

@pranavxc
Copy link
Member Author

pranavxc commented Sep 3, 2022 •
edited
Loading

@pranavxc This PR broke #3374. Is there a way to reconcile it? Why is setting super to '*' breaks permissions for lower level users?

We will enable it back, it's just a temporary workaround. I didn't realize that super role is used in #3374, I will look into that part again.

@dolsem
Copy link
Contributor

dolsem commented Sep 14, 2022

@pranavxc do you think you could ping me when it gets reenabled again please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavxc @dolsem @dstala