Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nc-gui): fix types and cleanup unused vars #3931

Merged
merged 4 commits into from
Oct 13, 2022
Merged

chore(nc-gui): fix types and cleanup unused vars #3931

merged 4 commits into from
Oct 13, 2022

Conversation

bcakmakoglu
Copy link
Contributor

@bcakmakoglu bcakmakoglu commented Oct 4, 2022 •
edited
Loading

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@bcakmakoglu bcakmakoglu added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Oct 4, 2022
@bcakmakoglu bcakmakoglu self-assigned this Oct 4, 2022
@bcakmakoglu bcakmakoglu added the trigger-CI force trigger CI even if PR in draft mode label Oct 4, 2022
@bcakmakoglu bcakmakoglu added the 🧱 Type: Refactoring Improving without affecting the existing functionality. label Oct 7, 2022
@bcakmakoglu bcakmakoglu marked this pull request as ready for review October 12, 2022 15:30
@bcakmakoglu bcakmakoglu removed 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. trigger-CI force trigger CI even if PR in draft mode labels Oct 13, 2022
pranavxc
pranavxc approved these changes Oct 13, 2022
View reviewed changes
packages/nc-gui/components/cell/Integer.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/cell/TextArea.vue Outdated Show resolved Hide resolved
@bcakmakoglu bcakmakoglu merged commit e798202 into develop Oct 13, 2022
@bcakmakoglu bcakmakoglu deleted the chore/typefix branch October 13, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavxc pranavxc pranavxc approved these changes

@wingkwong wingkwong Awaiting requested review from wingkwong

Assignees

@bcakmakoglu bcakmakoglu

Labels
🧱 Type: Refactoring Improving without affecting the existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcakmakoglu @pranavxc