Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nc-gui): Added fullscreen support to ERD #4911

Merged
merged 5 commits into from
Jan 24, 2023
Merged

feat(nc-gui): Added fullscreen support to ERD #4911

merged 5 commits into from
Jan 24, 2023

Conversation

mustafapc19
Copy link
Contributor

@mustafapc19 mustafapc19 commented Jan 23, 2023 •
edited
Loading

Ref: #4616

  • Fixed issue where ERD was being overflowed due to incorrect height
  • Fixed close button styling issue on settings modal

image

  • Added fullscreen toggle button to the top left corner

image

image

@mustafapc19 mustafapc19 marked this pull request as draft January 23, 2023 09:06
@mustafapc19 mustafapc19 marked this pull request as ready for review January 23, 2023 09:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Uffizzi Preview deployment-11949 was deleted.

@mustafapc19 mustafapc19 requested review from pranavxc and dstala and removed request for mertmit January 24, 2023 08:52
@dstala dstala merged commit 3d310a0 into develop Jan 24, 2023
@dstala dstala deleted the feat/erd-fullscreen branch January 24, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong left review comments

@pranavxc pranavxc pranavxc approved these changes

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustafapc19 @wingkwong @pranavxc @dstala