Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nc-gui): retrieve the comment part from the audit description #5513

Merged
merged 4 commits into from
Apr 25, 2023
Merged

fix(nc-gui): retrieve the comment part from the audit description #5513

merged 4 commits into from
Apr 25, 2023

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Apr 20, 2023 •
edited
Loading

Change Summary

  • currently comments would show The following comment has been created: <comment> which is from audit description. In comment component, we just need to show the comment part.
  • fix missing audit edit details
  • if details are not found, use description instead.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

before

image

after

image

@wingkwong wingkwong requested a review from dstala April 20, 2023 03:11
@wingkwong wingkwong added this to the Release 0.107.0-beta milestone Apr 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023 •
edited
Loading

Uffizzi Preview deployment-22813 was deleted.

dstala
dstala reviewed Apr 20, 2023
View reviewed changes
Copy link
Member

@dstala dstala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits are not visible (even in develop). Earlier - we displayed something like x was updated to xx with some strikes

Screenshot 2023-04-20 at 9 29 11 AM

@wingkwong wingkwong requested a review from dstala April 20, 2023 04:38
@dstala dstala merged commit 1fe1dc4 into develop Apr 25, 2023
@dstala dstala deleted the fix/comments branch April 25, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstala dstala dstala approved these changes

Assignees

@dstala dstala

Labels
None yet
Projects
None yet
Milestone
Release 0.107.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wingkwong @dstala