Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Commit to change email field input type #632

Merged
merged 2 commits into from Oct 12, 2021
Merged

Initial Commit to change email field input type #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfe2a63
Initial Commit for input type change
roman-rezinkin Oct 9, 2021
9a2eddb
Updated fixed files
roman-rezinkin Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions cypress/support/commands.js
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@
// commands please read more here:
// https://on.cypress.io/custom-commands
// ***********************************************
//
// @author Roman Rezinkin roman.rezinkin@hotmail.com
//
// -- This is a parent command --
// Cypress.Commands.add('login', (email, password) => { ... })
Expand Down Expand Up @@ -52,13 +52,13 @@ Cypress.Commands.add('signinOrSignup', (_args) => {
cy.wait(8000);
cy.get('body').trigger('mousemove');
cy.contains('Let\'s Begin').click();
cy.get('input[type="text"]', { timeout: 12000 }).type(args.username);
cy.get('input[type="email"]', { timeout: 12000 }).type(args.username);
cy.get('input[type="password"]').type(args.password);
cy.get('button:contains("SIGN UP")').click()

// handle signin
} else {
cy.get('input[type="text"]', { timeout: 12000 }).type(args.username);
cy.get('input[type="email"]', { timeout: 12000 }).type(args.username);
cy.get('input[type="password"]').type(args.password);
cy.get('button:contains("SIGN IN")').click()
}
Expand Down
2 changes: 1 addition & 1 deletion cypress/support/page_objects/mainPage.js
View file
Open in desktop
Expand Up @@ -71,7 +71,7 @@ export class _mainPage {

// Redirected to new URL, feed details
//
cy.get('input[type="text"]').type(userCred.username)
cy.get('input[type="email"]').type(userCred.username)
cy.get('input[type="password"]').type(userCred.password)
cy.get('button:contains("SIGN UP")').click()

Expand Down
4 changes: 2 additions & 2 deletions cypress/support/page_objects/navigation.js
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ export class _loginPage {
signIn(userCredentials) {
this.go(urlPool.ncUrlSignIn)

cy.get('input[type="text"]', {timeout: 6000}).type(userCredentials.username)
cy.get('input[type="email"]', {timeout: 6000}).type(userCredentials.username)
cy.get('input[type="password"]').type(userCredentials.password)
cy.get('button:contains("SIGN IN")').click()

Expand All @@ -38,7 +38,7 @@ export class _loginPage {
signUp(userCredentials) {
this.go(urlPool.ncUrlSignUp)

cy.get('input[type="text"]', {timeout: 6000}).type(userCredentials.username)
cy.get('input[type="email"]', {timeout: 6000}).type(userCredentials.username)
cy.get('input[type="password"]').type(userCredentials.password)
cy.get('button:contains("SIGN UP")').click()

Expand Down
2 changes: 1 addition & 1 deletion packages/nocodb/src/lib/public/index.html
View file
Open in desktop
Expand Up @@ -371,7 +371,7 @@ <h2 class="my-5 title grey--text text--darken-2">Instant APIs on any Database</h
<!-- real people should not fill this in and expect good things - do not remove this or risk form bot signups-->
<div style="position: absolute; left: -5000px;" aria-hidden="true">
<input
type="text"
type="email"
name="b_34a5d2680bab8825d485af859_f04c6c8b8d"
tabindex="-1" value=""></div>

Expand Down