New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Commit to change email field input type #632
Conversation
Before any kind of merging, I need to verify a small issue that I am experiencing. When I make my changes and try to run the instructions as per the README (https://github.com/nocodb/nocodb#development-setup), I do not see my changes being reflected when I inspect the elements. The readme mentions that the code should live the change, but I am not seeing that. Is there some sort of build process that I can get instructions for? |
Thank you so much. For the first commit, signature is missing. One of our user was able to sign the commits even after submitting PRs like this. |
0a79848
to
57e3b46
Compare
Signed-off-by: roman-rezinkin <roman.rezinkin@hotmail.com>
57e3b46
to
dfe2a63
Compare
Signed-off-by: roman-rezinkin <roman.rezinkin@hotmail.com>
@o1lab I have updated the commit signatures. I found it quite hard to sign off on a previous commit. There must be something up with my development setup. Regardless, I have fixed the issue and also introduced the changes. Please feel free to review :) |
Hey @roman-rezinkin : thank you for the effort. It would be helpful for others to know how to sign once commited. Although we've something documented - we can put alternatives. I guess having a simple CLA is easier than git commit signature. |
@all-contributors please add @roman-rezinkin for code |
I've put up a pull request to add @roman-rezinkin! 🎉 |
You need to access UI via |
Initial Commit to change email field input type
This PR looks to fix issue #627.
I have changed the input type from text to email.
In my attempt to replicate the capitalization issue brought up in #627, I was unable to replicate the problem. I tested using Chrome. Mozilla, and Microsoft Edge, and each type I inputted my email into the field, it would not capitalize the first letter. Being on a Windows computer, I do not have access to Safari (As mentioned in the issue), so I presume that the fix should help resolve the issue in Safari.