Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Commit to change email field input type #632

Merged
merged 2 commits into from Oct 12, 2021

Conversation

roman-rezinkin
Copy link
Contributor

This PR looks to fix issue #627.

I have changed the input type from text to email.
In my attempt to replicate the capitalization issue brought up in #627, I was unable to replicate the problem. I tested using Chrome. Mozilla, and Microsoft Edge, and each type I inputted my email into the field, it would not capitalize the first letter. Being on a Windows computer, I do not have access to Safari (As mentioned in the issue), so I presume that the fix should help resolve the issue in Safari.

@roman-rezinkin
Copy link
Contributor Author

Before any kind of merging, I need to verify a small issue that I am experiencing. When I make my changes and try to run the instructions as per the README (https://github.com/nocodb/nocodb#development-setup), I do not see my changes being reflected when I inspect the elements. The readme mentions that the code should live the change, but I am not seeing that. Is there some sort of build process that I can get instructions for?

@o1lab
Copy link
Member

o1lab commented Oct 10, 2021

Thank you so much.

For the first commit, signature is missing. One of our user was able to sign the commits even after submitting PRs like this.

Signed-off-by: roman-rezinkin <roman.rezinkin@hotmail.com>
Signed-off-by: roman-rezinkin <roman.rezinkin@hotmail.com>
@roman-rezinkin
Copy link
Contributor Author

@o1lab I have updated the commit signatures. I found it quite hard to sign off on a previous commit. There must be something up with my development setup. Regardless, I have fixed the issue and also introduced the changes. Please feel free to review :)

@o1lab
Copy link
Member

o1lab commented Oct 11, 2021

Hey @roman-rezinkin : thank you for the effort.

It would be helpful for others to know how to sign once commited. Although we've something documented - we can put alternatives. I guess having a simple CLA is easier than git commit signature.

@pranavxc pranavxc merged commit 3025f1a into nocodb:master Oct 12, 2021
@pranavxc
Copy link
Member

@all-contributors please add @roman-rezinkin for code

@allcontributors
Copy link
Contributor

@pranavxc

I've put up a pull request to add @roman-rezinkin! 🎉

@pranavxc
Copy link
Member

Before any kind of merging, I need to verify a small issue that I am experiencing. When I make my changes and try to run the instructions as per the README (https://github.com/nocodb/nocodb#development-setup), I do not see my changes being reflected when I inspect the elements. The readme mentions that the code should live the change, but I am not seeing that. Is there some sort of build process that I can get instructions for?

You need to access UI via http://localhost:3000

akbarpasha pushed a commit to akbarpasha/nocodb that referenced this pull request Nov 15, 2021
Initial Commit to change email field input type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants