Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/expanded record ux #7298

Merged
merged 22 commits into from Dec 29, 2023
Merged

Fix/expanded record ux #7298

merged 22 commits into from Dec 29, 2023

Conversation

rameshmane7218
Copy link
Collaborator

@rameshmane7218 rameshmane7218 commented Dec 27, 2023 •
edited

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@rameshmane7218 rameshmane7218 marked this pull request as ready for review December 27, 2023 03:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 27, 2023 •
edited

Uffizzi Preview deployment-43544 was deleted.

@dstala
Copy link
Member

dstala commented Dec 27, 2023

  • usage of tab when fields are not visible (need scroll)
  • rich text doesn’t function when i start typing
  • checkbox, i should be able to toggle on pressing enter key
  • percent field, auto select if some text exists
  • comment window, after pressing enter key - cursor should be placed to take subsequent input in the comments modal

wingkwong
wingkwong reviewed Dec 27, 2023
View reviewed changes
packages/nc-gui/components/cell/Currency.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/cell/RichText.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/cell/SingleSelect.vue Outdated
v-if="!(active || isEditable)"
class="w-full"
:class="{
'!px-2': isExpandedFormOpen,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the time, you don't need ! for div. please double check. (apply to all)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

packages/nc-gui/components/smartsheet/expanded-form/Comments.vue Outdated Show resolved Hide resolved
@wingkwong wingkwong added the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Dec 28, 2023
@dstala dstala removed the 🛑 Status: Do Not Merge Used in PR only. The PR cannot be merged due to some reasons. label Dec 28, 2023
wingkwong
wingkwong requested changes Dec 28, 2023
View reviewed changes
packages/nc-gui/components/cell/User.vue Outdated Show resolved Hide resolved
packages/nc-gui/components/cell/User.vue Outdated Show resolved Hide resolved
@dstala dstala merged commit 9c4efd4 into develop Dec 29, 2023
22 checks passed
@dstala dstala deleted the fix/expanded-record-ux branch December 29, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong requested changes

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Expanded record UX
3 participants
@rameshmane7218 @dstala @wingkwong