Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/expanded record ux #7298

Merged
merged 22 commits into from
Dec 29, 2023
Merged

Fix/expanded record ux #7298

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e40ed4e
fix: disable input field after Enter key is pressed
rameshmane7218 Dec 25, 2023
e8424af
fix: tab navigation and focus outline issue
rameshmane7218 Dec 25, 2023
ffcf847
fix: number input up-down button should be hidden
rameshmane7218 Dec 25, 2023
4bce0c5
fix: form view double border issue
rameshmane7218 Dec 25, 2023
cba6af4
fix: input field double border issue of shared form
rameshmane7218 Dec 25, 2023
e6a60e9
fix: long/rich text field default value issue in form view
rameshmane7218 Dec 25, 2023
8e7aaf8
fix: field alignment issue in expanded form
rameshmane7218 Dec 26, 2023
e3e3e7d
fix: lint errors
rameshmane7218 Dec 26, 2023
04b55f5
fix: form field alignment issue
rameshmane7218 Dec 26, 2023
5309785
Merge branch 'develop' into fix/expanded-record-ux
rameshmane7218 Dec 27, 2023
9116bb7
fix: comment input focus issue after saving comment
rameshmane7218 Dec 27, 2023
c17860b
fix: checkbox toggle issue on pressing enter key
rameshmane7218 Dec 27, 2023
4f4a071
fix: percent field text select on focus issue
rameshmane7218 Dec 27, 2023
291532a
fix: review changes
rameshmane7218 Dec 27, 2023
42fcaa4
fix: text area exapnd on enter keypress in form
rameshmane7218 Dec 28, 2023
44754e1
fix: tab focus issue in shared form and expanded form
rameshmane7218 Dec 28, 2023
466049f
fix: expanded comment input focus issue
rameshmane7218 Dec 28, 2023
a5fd82d
fix: review changes
rameshmane7218 Dec 28, 2023
d12a187
fix: review changes of select dropdown fields
rameshmane7218 Dec 29, 2023
51954f1
fix: form submit button focus css issue
rameshmane7218 Dec 29, 2023
937ac53
fix: review changes
rameshmane7218 Dec 29, 2023
37ab476
fix: added missing line break
rameshmane7218 Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/nc-gui/pages/index/[typeOrId]/form/[viewId]/index/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { ColumnType } from 'nocodb-sdk'
import { RelationTypes, UITypes, isVirtualCol } from 'nocodb-sdk'
import { ref } from 'vue'
import { StreamBarcodeReader } from 'vue-barcode-reader'
import { iconMap, useSharedFormStoreOrThrow } from '#imports'
import { iconMap, useGlobal, useSharedFormStoreOrThrow } from '#imports'

const { sharedFormView, submitForm, v$, formState, notFound, formColumns, submitted, secondsRemain, isLoading } =
useSharedFormStoreOrThrow()
Expand All @@ -21,6 +21,7 @@ function isRequired(_columnObj: Record<string, any>, required = false) {
return !!(required || (columnObj && columnObj.rqd && !columnObj.cdf))
}

const { isMobileMode } = useGlobal()
wingkwong marked this conversation as resolved.
Show resolved Hide resolved
const fieldTitleForCurrentScan = ref('')

const scannerIsReady = ref(false)
Expand Down Expand Up @@ -68,7 +69,13 @@ const onDecode = async (scannedCodeValue: string) => {
</script>

<template>
<div class="h-full flex flex-col items-center">
<div
class="h-full flex flex-col items-center"
:class="{
mobile: isMobileMode,
desktop: !isMobileMode,
}"
wingkwong marked this conversation as resolved.
Show resolved Hide resolved
>
<div
class="color-transition flex flex-col justify-center gap-2 w-full max-w-[max(33%,600px)] m-auto py-4 pb-8 px-16 md:(bg-white dark:bg-slate-700 rounded-lg border-1 border-gray-200 shadow-xl)"
>
Expand Down