Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to dotnet test for NUnit #967

Closed
jskeet opened this issue Aug 29, 2017 · 4 comments · Fixed by #1283
Closed

Move to dotnet test for NUnit #967

jskeet opened this issue Aug 29, 2017 · 4 comments · Fixed by #1283
Assignees
@jskeet
Labels
build

Comments

@jskeet
Copy link
Member

jskeet commented Aug 29, 2017

The NUnit3TestAdapter nuget package is the relevant one here.

Build scripts etc need changing, of course.
@jskeet jskeet self-assigned this Aug 29, 2017
@jskeet
Copy link
Member Author

jskeet commented Aug 29, 2017

Just tried this, and while it's simple to do, the test category filtering doesn't fully work yet - it looks like it executes all the tests and just filters the results. I need to validate this and report a bug.

@jskeet jskeet mentioned this issue Nov 17, 2017
Closed
@jskeet
Copy link
Member Author

jskeet commented Mar 28, 2018

Tried again with NUnit 3.10, and the same problem persists. (We also get some test failures, oddly enough. I'll look into that when I get the time.) Haven't found time to investigate further and report the bug yet.

Numbers:

  • Current approach, all tests: just under 2 minutes
  • Current approach, filter out slow tests: 18 seconds
  • dotnet test, all tests: about 2 1/2 minutes
  • dotnet test, filter out slow tests: about 2 minutes

@jskeet
Copy link
Member Author

jskeet commented Mar 29, 2018

It looks like it's not that it's running the meant-to-be-filtered-out tests - it seems that just applying the filter takes a very long time.

After removing the slow tests entirely, running dotnet test -f netcoreapp2.0 -c Release takes about 20 seconds, but running dotnet test -f netcoreapp2.0 -c Release --filter TestCategory!=Slow takes 2 1/2 minutes. Will try to reproduce outside Noda Time...

@jskeet
Copy link
Member Author

jskeet commented Apr 2, 2018

Reported via nunit/nunit3-vs-adapter#497 - the NUnit team are discussing how to proceed, but the issue is now understood, at least.

@jskeet jskeet added the build label Apr 2, 2018
jskeet added a commit to jskeet/nodatime that referenced this issue Feb 15, 2019
@jskeet
Move to NUnit3TestAdapter, so dotnet test works
da7e508 
Fixes nodatime#967.

We probably don't want to actually merge this until 3.13.0 is out, as that will fix the slow test running with filters.
@jskeet jskeet mentioned this issue Feb 15, 2019
Merged
jskeet added a commit to jskeet/nodatime that referenced this issue Feb 15, 2019
@jskeet
Move to NUnit3TestAdapter, so dotnet test works
7296c6a 
Fixes nodatime#967.

We probably don't want to actually merge this until 3.13.0 is out, as that will fix the slow test running with filters.

Additionally, run TzdbCompiler tests in CI. This needs a little tweak to avoid Windows-oriented tests on Linux.
jskeet added a commit that referenced this issue Feb 15, 2019
@jskeet
Move to NUnit3TestAdapter, so dotnet test works
12f1515 
Fixes #967.

We probably don't want to actually merge this until 3.13.0 is out, as that will fix the slow test running with filters.

Additionally, run TzdbCompiler tests in CI. This needs a little tweak to avoid Windows-oriented tests on Linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move to NUnit3TestAdapter, so dotnet test works jskeet/nodatime
1 participant
@jskeet