if /tmp/ not present example fails (at least on Windows)

[cthedot]

trying the formidable example script on Windows (7, 64bit, Nodejs 0.5.3 native .exe) yields the following error:

events.js:48
throw arguments[1]; // Unhandled 'error' event
^
Error: ENOENT, The system cannot find the file specified. '\tmp\2c4faab430e45c01747400ba
48f1465f'

When adding a \tmp\ folder on hard disk volume it works flawlessly (default temp folder should be environ var TEMP or TMP which would be c:\temp or c:\Windows\temp for untampered installations at least).
I guess (maybe naively) this could be fixed easily? Giving an informative error message would be at least something. :)

BTW, nice lib!

[felixge]

I guess I could change the default file upload location to process.cwd(). What do you think?

[Pita]

Thats how we solve it at etherpad lite

var tempDirectory = "/tmp/";

//tempDirectory changes if the operating system is windows
if(os.type().indexOf("Windows") > -1)
{
  tempDirectory = "c:\\Temp\\";
}
form.uploadDir = tempDirectory;

[cthedot]

Guess I am not competent enough regarding process.cwd() but IMHO Pitas approach seems a bit questionable. At least my Win7 install has no c:\temp folder (I think default is normally c:\windows\temp but that also assumes install dir of Windows is the default).
Is there no way to check for a folder and if not present fall back to process.cwd() which seems logical (from my naive standpoint :).
Actually I just checked and why not try to use process.ENV.TEMP or process.ENV.TMP (default WIndows install sets TEMP in all cases at least I am quite sure)? Is this set on OSX/Linux? Or check for Win and use process.ENV.TEMP or process.ENV.TMP or log an error message?

Sorry for not being much of a help but I am more or less new to node.

[cthedot]

Should this work?

var fs = require('fs');
fs.stat(process.env.TEMP).isDirectory()

problem is that fs.stat returns simple undefined (node 0.5.3), ?

[cthedot]

Sorry (my last comment is proper bullsh*t), this should be (and works too):

node -e "var fs = require('fs');fs.stat(process.env.TEMP, function(x, y
) {console.log(y.isDirectory())})"
true

(somehow this does not work on console (yet) but seems a known bug with { and } in the console)

[Pita]

@cthedot You're right, looks like the tmp folder differs between windows versions. Thx for that hint

[cthedot]

nice you care about Windows at all :)

[cthedot]

sorry, wrong button, did not meant to close the issue

[felixge]

Ok, I think using fs.statSync() we should choose between: '/tmp', process.env.TEMP, process.cwd() when the module is initially required. I won't have time to do the patch right away, but I'd merge a pull request.

[cthedot]

I tried to implement this here https://github.com/cthedot/node-formidable/blob/master/lib/incoming_form.js
but as this is my very first Nodejs experience should be tested before pulled (test only on Win7-64). Any comments very welcome :)

[tommedema]

Wait.. why are you using synchronous blocking functions? My server will be dealing with tons of form requests. Having each form request block would be like hell on earth. :)

[cthedot]

actually a good question, in Felix last comment he suggested it, async is no problem here?

[felixge]

I will take care of this, I mean to use sync functions when the module is loading.

[tommedema]

Hmm right, I still don't see the necessity though. It feels wrong to use blocking functions when there is no need.

I assume it's not really an issue though when it's solely during initialization of the module.

[felixge]

I assume it's not really an issue though when it's solely during initialization of the module.

require is blocking, and actually performs much more I/O than the stat calls will. It is not an issue.

[felixge]

Released as v1.0.4.