Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HIDAsync & expand getdeviceinfo #506

Merged
merged 10 commits into from
Nov 26, 2023

Conversation

Julusian
Copy link
Contributor

@Julusian Julusian commented May 5, 2023

Retrying #474 #499

@Julusian
Copy link
Contributor Author

Julusian commented May 5, 2023

@todbot this fixes those macos compiler warnings.

I realised that I didnt update the readme as part of this, which I shall do now

And typescript typings got included in this PR too for some reason. Do you mind them being here, or would you rather they were kept elsewhere like they are for other version? https://github.com/Julusian/node-hid/blob/feat/hid-async-v2/nodehid.d.ts

@Julusian
Copy link
Contributor Author

@todbot any chance of getting this merged soon if I fix the merge conflict?

@todbot
Copy link
Contributor

todbot commented Nov 25, 2023

Yes! Let's try it out and I'll test existing code against the hardware I have. Thank you for your patience.

@Julusian
Copy link
Contributor Author

Julusian commented Nov 25, 2023

Github lied about a merge conflict, so it is ready now.

A couple of months ago, I pushed this live to beta builds of Companion. Based on the analytics we have, that means this code is with ~1500 users (that are connected to the internet, there are likely more who are not online), a majority of who will be using a streamdeck (or possibly an xkeys, or a couple of other hid devices).
I haven't heard any reports of issues so far.

I would also like to get #507 merged too if possible, but I will need to do some updates to it first

@todbot todbot merged commit d279b46 into node-hid:master Nov 26, 2023
9 checks passed
@todbot
Copy link
Contributor

todbot commented Nov 26, 2023

Initial tests look good. Thank you so much.
Companion looks really neat. Great job on making such a professional tool.
I have a Streamdeck somewhere and I wish I had a reason to use it with Companion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants