Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use serialize-json to support encode/decode buffer, date, undef… #10

Merged
merged 2 commits into from
Feb 20, 2017

Conversation

shaoshuai0102
Copy link
Contributor

…ined

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@shaoshuai0102, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gxcsoccer and @fengmk2 to be potential reviewers.

@codecov-io
Copy link

codecov-io commented Feb 20, 2017

Codecov Report

Merging #10 into master will decrease coverage by -0.57%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   97.07%   96.51%   -0.57%     
==========================================
  Files          15       15              
  Lines         718      717       -1     
==========================================
- Hits          697      692       -5     
- Misses         21       25       +4
Impacted Files Coverage Δ
lib/default_transcode.js 100% <100%> (ø)
lib/connection.js 93.05% <ø> (-2.78%)
lib/leader.js 94.61% <ø> (-1.2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8b815...f0068ff. Read the comment docs.

Copy link
Member

@gxcsoccer gxcsoccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gxcsoccer
Copy link
Member

等 ci

@gxcsoccer gxcsoccer merged commit 6e2ec86 into master Feb 20, 2017
@shaoshuai0102 shaoshuai0102 deleted the feat-support-undefined-date-buffer branch February 20, 2017 09:24
@gxcsoccer
Copy link
Member

+ cluster-client@1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants