Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use address@2 (#52) #53

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: use address@2 (#52) #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict';

module.exports = {
extends: 'eslint-config-egg',
parserOptions: {
Expand Down
74 changes: 0 additions & 74 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop

This file was deleted.

7 changes: 2 additions & 5 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,13 @@ name: CI
on:
push:
branches: [ master ]

pull_request:
branches: [ master ]

workflow_dispatch: {}

jobs:
Job:
name: Node.js
uses: artusjs/github-actions/.github/workflows/node-test.yml@v1
uses: node-modules/github-actions/.github/workflows/node-test.yml@master
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The verification script attempted to confirm the existence and accessibility of the GitHub Actions workflow file at the specified path in the repository node-modules/github-actions. The script used the GitHub API to check for the file .github/workflows/node-test.yml at the master branch but received a 404 HTTP error, indicating that the file could not be found.

This suggests that the updated workflow path specified in the .github/workflows/nodejs.yml file might be incorrect or the repository structure has changed, making the path invalid.

Actionable Follow-up

Given the critical nature of CI/CD workflows and the potential impact of an incorrect workflow path, it is essential to address this issue promptly. The development team should verify the correct path to the workflow file and update the .github/workflows/nodejs.yml accordingly.

  • Incorrect Workflow Path: The path node-modules/github-actions/.github/workflows/node-test.yml@master does not exist or is not accessible. This needs correction to ensure the CI/CD process functions correctly.
Analysis chain

Update to workflow path looks good.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new workflow path is valid and accessible.

# Test: Check if the workflow file exists at the specified path.
gh api repos/node-modules/github-actions/contents/.github/workflows/node-test.yml@master

Length of output: 227

with:
os: 'ubuntu-latest'
version: '14, 16, 18'
version: '14, 16, 18, 20, 22'
6 changes: 1 addition & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,10 @@ on:
push:
branches: [ master ]

workflow_dispatch: {}

jobs:
release:
name: Node.js
uses: artusjs/github-actions/.github/workflows/node-release.yml@v1
uses: node-modules/github-actions/.github/workflows/node-release.yml@master
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The verification script attempted to confirm the existence of the workflow file at the specified path in the GitHub repository node-modules/github-actions. The script used the GitHub CLI tool (gh) to query the GitHub API for the file .github/workflows/node-release.yml at the branch master. However, the response from the GitHub API indicated that the file could not be found, returning a "Not Found" error with a 404 HTTP status code.

This suggests that the updated workflow path specified in the .github/workflows/release.yml file may be incorrect or the file does not exist at the specified location in the repository. This could potentially lead to failures when the workflow is triggered, as the GitHub Actions runner will not be able to locate the referenced workflow file.

Given this information, it is necessary to flag this issue to ensure it is addressed.

Workflow Path Update Issue Detected

The verification process for the updated workflow path in .github/workflows/release.yml has identified an issue. The specified path does not correspond to an existing file in the repository, which could lead to failures during workflow execution. Please review and correct the workflow path.

  • File: .github/workflows/release.yml
  • Line: 10
  • Issue: The specified workflow file node-modules/github-actions/.github/workflows/node-release.yml@master does not exist.
Analysis chain

Update to workflow path looks good.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the new workflow path is valid and accessible.

# Test: Check if the workflow file exists at the specified path.
gh api repos/node-modules/github-actions/contents/.github/workflows/node-release.yml@master

Length of output: 230

secrets:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GIT_TOKEN: ${{ secrets.GIT_TOKEN }}
with:
checkTest: false
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ Most likely network error, check that your `/etc/hosts` and make sure the conten
| :---: | :---: | :---: | :---: | :---: | :---: |
[<img src="https://avatars.githubusercontent.com/u/52845048?v=4" width="100px;"/><br/><sub><b>snapre</b></sub>](https://github.com/snapre)<br/>|[<img src="https://avatars.githubusercontent.com/u/56271907?v=4" width="100px;"/><br/><sub><b>yavuzakyuz</b></sub>](https://github.com/yavuzakyuz)<br/>|[<img src="https://avatars.githubusercontent.com/u/197375?v=4" width="100px;"/><br/><sub><b>antife-yinyue</b></sub>](https://github.com/antife-yinyue)<br/>

This project follows the git-contributor [spec](https://github.com/xudafeng/git-contributor), auto updated at `Wed Sep 21 2022 23:10:27 GMT+0800`.
This project follows the git-contributor [spec](https://github.com/xudafeng/git-contributor), auto updated at `Wed May 08 2024 15:54:54 GMT+0800`.

<!-- GITCONTRIBUTOR_END -->

Expand Down
2 changes: 0 additions & 2 deletions bin/detect-port.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#!/usr/bin/env node

'use strict';

const pkg = require('../package');

const args = process.argv.slice(2);
Expand Down
4 changes: 1 addition & 3 deletions lib/detect-port.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
'use strict';

const net = require('net');
const debug = require('util').debuglog('detect-port');
const address = require('address');
const debug = require('debug')('detect-port');

module.exports = (port, callback) => {
let hostname = '';
Expand Down
4 changes: 1 addition & 3 deletions lib/wait-port.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
'use strict';

const debug = require('debug')('wait-port');
const debug = require('util').debuglog('wait-port');
const detect = require('./detect-port');

const sleep = ms => new Promise(resolve => setTimeout(resolve, ms));
Expand Down
19 changes: 10 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,26 @@
"url": "git://github.com/node-modules/detect-port.git"
},
"dependencies": {
"address": "^1.0.1",
"debug": "4"
"address": "^2.0.2"
},
"devDependencies": {
"command-line-test": "1",
"egg-bin": "^5.2.0",
"eslint": "^8.23.1",
"eslint-config-egg": "^12.0.0",
"git-contributor": "1",
"mm": "^2.1.0",
"pedding": "^1.1.0",
"power-assert": "^1.6.1"
"egg-bin": "6",
"eslint": "8",
"eslint-config-egg": "12",
"git-contributor": "2",
"mm": "3",
"pedding": "1"
},
"scripts": {
"test": "egg-bin test",
"ci": "npm run lint && egg-bin cov",
"lint": "eslint .",
"contributor": "git-contributor"
},
"engines": {
"node": ">= 14.0.0"
},
"homepage": "https://github.com/node-modules/detect-port",
"license": "MIT"
}
2 changes: 0 additions & 2 deletions test/cli.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use strict';

const path = require('path');
const assert = require('assert');
const CliTest = require('command-line-test');
Expand Down
5 changes: 1 addition & 4 deletions test/detect-port.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
'use strict';

const mm = require('mm');
const dns = require('dns');
const net = require('net');
const pedding = require('pedding');
const address = require('address');
const assert = require('power-assert');

const assert = require('assert');
const detectPort = require('..');

describe('test/detect-port.test.js', () => {
Expand Down
3 changes: 0 additions & 3 deletions test/wait-port.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
'use strict';

const mm = require('mm');
const net = require('net');

const { waitPort } = require('..');

describe('test/wait-port.test.js', () => {
Expand Down