Fixes regression introduced by #719 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2016
|
Can't believe I missed this! Thanks for cleaning up after me and adding the test case for this regression 👍 |
|
@ltegman No problem! 🍻 |
|
A fixed 9.0.x would be great :) |
|
@vrinek Any thoughts? |
|
Thanks for the fix! |
vrinek
added a commit
that referenced
this pull request
Oct 28, 2016
Fixes regression introduced by #719
|
Just published in v8.2.1 & v9.0.1 🎉 /cc @aredridel |
|
Thank you so much! Tests pass for us with those! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for empty objects in the body and spec.
It also fixes a regression that would cause the library to throw an error if an empty object was passed in the body.
CC @vrinek