LibreSSL Support #5
Conversation
|
Thank you @bompi88 , would it be possible to adapt the travis script so we run tests on MacOS ? |
lib/pki/certificate_authority.js
Outdated
| @@ -469,7 +478,9 @@ CertificateAuthority.prototype.verifyCertificate = function(certificate_file,cal | |||
|
|
|||
| var options = {cwd: self.rootDir}; | |||
| toolbox.setEnv("OPENSSL_CONF", toolbox.make_path(self.configFile)); | |||
There was a problem hiding this comment.
Could we avoid code duplication ?
lib/pki/toolbox.js
Outdated
| @@ -264,6 +273,33 @@ function displaySubtitle(str, option_callback) { | |||
|
|
|||
| exports.displaySubtitle = displaySubtitle; | |||
|
|
|||
| function getEnvironmentVarNames() { | |||
| return Object.keys(process.env).map(function(varName) { return { key: varName, pattern: '\\$ENV\\:\\:' + varName }; }); | |||
There was a problem hiding this comment.
Would be good to export only env variable that are set by us , not the one that exists on the system .
( this could create a backdoor)
| @@ -341,21 +341,21 @@ CertificateAuthority.prototype.revokeCertificate = function(certificate,params,c | |||
| "certificateHold", "removeFromCRL" | |||
| ]; | |||
|
|
|||
| var options = {cwd: self.rootDir , openssl_conf:toolbox.make_path(self.configFile) }; | |||
| var configFile = toolbox.generateStaticConfig("conf/caconfig.cnf", { cwd: self.rootDir }); | |||
There was a problem hiding this comment.
@erossignon Should conf/caconfig.cnf be self.configFile?
|
|
||
| if (["OPENSSL_CONF"].indexOf(varName) >= 0) { |
There was a problem hiding this comment.
@erossignon I assume OPENSSL_CONF is needed in systems` environment vars?
|
@erossignon I see I triggered a lot of builds in travis, which seems to stall, feel free to cancel all except the last one. Seems like macos builds is not always starting and hangs for a long time. Should maybe consider only linux build matrix with openssl and libressl. |
Generate static config files to support LibreSSL (issue #4 ). Also do not provide random generator files if LibreSSL is detected, as it's not a viable CLI option. @erossignon If there's something you want me to change, let me know.