Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property UI of mqtt-out node shows invalid typedInput when pressing Enter in the name field #3780

Closed
kazuhitoyokoi opened this issue Jul 18, 2022 · 1 comment · Fixed by #3788

Comments

@kazuhitoyokoi
Copy link
Member

Current Behavior

After pressing Enter key in the name field on the property UI of the mqtt-out node, I encountered the invalid typedInput menu.

スクリーンショット 2022-07-18 21 10 09

I think that this problem is not specific to the mqtt-out node. For example, I found that there are the following issues.

  • inject, range, exec, filter, html, json, xml, yaml node: UI switched focus from name field to the other field.
  • debug, switch, change, template, trigger, split, sort, write file, read file node: UI opened the typedInput menu of another field.
  • mqtt-out, join node: UI showed invalid typedInput menu.
  • complete, catch, and status node: UI showed "Click nodes to select" notification dialog.
  • function node: UI opened JavaScript editor.

I thought that the first object in the property UI seems to be executed after pressing Enter key in other fields.

Expected Behavior

Enter key event is ignored as same as text input in Visual JSON editor.

スクリーンショット 2022-07-18 21 45 30

Steps To Reproduce

  1. Place the mqtt-out node on the workspace.
  2. Open the property UI of the mqtt-out node.
  3. Click the name field on the property UI.
  4. Press Enter key in the name field
    -> Flow editor shows the invalid typedInput.

Example flow

No response

Environment

  • Node-RED version: 3.0.0
  • Node.js version: 16.16.0
  • npm version: 8.11.0
  • Platform/OS: macOS Monterey 12.4 on MacBook Air (M1, 2020)
  • Browser: Google Chrome 103.0.5060.114 (Official Build)(arm64)
@dceejay dceejay added the bug label Jul 19, 2022
knolleary added a commit that referenced this issue Jul 20, 2022
Fixes #3780

Otherwise they act as type="submit" and the browser will click on them
when enter is pressed in an input
@kazuhitoyokoi
Copy link
Member Author

@knolleary Thank you for fixing it. I checked Node-RED v3.0.1. It works correctly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants