Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button type to the adding SSH key button #3866

Merged
merged 3 commits into from Sep 12, 2022

Conversation

kazuhitoyokoi
Copy link
Member

@kazuhitoyokoi kazuhitoyokoi commented Sep 3, 2022

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

The project feature dialog has the same issue as #3788.

Screen Shot 2022-09-03 at 21 10 08

After pressing the enter key in the above area, the UI to add the SSH key emerges incorrectly.

Screen Shot 2022-09-03 at 21 38 15

In this pull request, I added the button type into the button to avoid the issue.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Sep 3, 2022

Coverage Status

Coverage increased (+0.03%) to 68.373% when pulling 745607b on kazuhitoyokoi:master-fixbutton4addsshkey into a5d7f7a on node-red:master.

@kazuhitoyokoi
Copy link
Member Author

I found the same issues in another project feature dialog. Therefore, I added the commit to fix it.

Screen Shot 2022-09-04 at 22 15 20

@kazuhitoyokoi
Copy link
Member Author

I added the additional commit to fix the same issues in node properties. Some fixes had been reported in #3780.

complete, catch, and status node: UI showed "Click nodes to select" notification dialog.
function node: UI opened JavaScript editor.

@knolleary knolleary merged commit 30f4524 into node-red:master Sep 12, 2022
@kazuhitoyokoi
Copy link
Member Author

@knolleary Thank you. Could you add the backport-2.x tag to this pull request? I think that the last commit for core codes is a common problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants