join-node-keep-top-level-properties

[dceejay]

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Proposed changes

When msgs get joined into objects currently the final msg to arrive is used as the base msg to add the newly joined payload to. If anyone has added extra top level properties to any of the other messages (maybe via a divergent path) they will be dropped.

This change make the the top level message be an accumulation of previous msg top level properties then with the new payload.
This should be transparent to users as the last msg in will still set all the same properties as previously… just there may now be a few more.

Fixes the Issue #1782

Checklist

• I have read the contribution guidelines
• For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
• I have run grunt to verify the unit tests pass
• I have added suitable unit tests to cover the new/changed functionality

[knolleary]

140 commits and 107 files changed.... oops. You've submitted a change from the 0.19 branch to the master branch.

I've retargeted the PR to the 0.19 branch and it looks better. Going to merge into 0.19 - if you want this in master (should we do a maintenance release ahead of 0.19) you'll need to submit a new PR that patches it into master.