Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Korean locales #2002

Closed
wants to merge 1 commit into from
Closed

add Korean locales #2002

wants to merge 1 commit into from

Conversation

gimapei
Copy link

@gimapei gimapei commented Dec 15, 2018

  • Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
It's just locale file for Korean

Proposed changes

Checklist

  • [ x ] I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • [ x ] I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@jsf-clabot
Copy link

jsf-clabot commented Dec 15, 2018

CLA assistant check
All committers have signed the CLA.

@gimapei
Copy link
Author

gimapei commented Dec 15, 2018

hello, I am Joe form korea,
I added language files for Korean.
I think it will help many Koreans.

thanks. bye

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.466% when pulling a252514 on gimapei:master into a6ef755 on node-red:master.

@knolleary
Copy link
Member

Hi, thanks for this.

Please can you use the dev branch as that is the next release and contains a few changes to the messages.

We would also like this to be reviewed by the community before accepting as we cannot verify the translations ourselves.

@gimapei
Copy link
Author

gimapei commented Dec 16, 2018

sure. I can work for dev branch.
it take's some time

@knolleary
Copy link
Member

Closing in preference to #2004

@knolleary knolleary closed this Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants