Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width on inject node property #2307

Merged
merged 1 commit into from Oct 4, 2019
Merged

Fix width on inject node property #2307

merged 1 commit into from Oct 4, 2019

Conversation

kazuhitoyokoi
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

On the inject node property UI, the pull-down menu and checkboxes are wider than specified values. This problem seemed to occur because the order of the styles to apply was changed in Node-RED v1.0.0. Therefore, I added !important to set higher priority.

image

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.534% when pulling 1c424e2 on kazuhitoyokoi:master-fixinjectnode into 2c89b2d on node-red:master.

@knolleary knolleary merged commit 81f8060 into node-red:master Oct 4, 2019
@kazuhitoyokoi
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants