New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Russian Locale #2531
Add Russian Locale #2531
Conversation
Clabot states "CLA: not signed yet", however it should be. When I click the badge it opens the CLA page with "You have signed the CLA for node-red/node-red" at the top. |
The usual reasons for this is that the commits have an email address that is not linked to your github account. |
What are the options to fix it? I use GitHub's |
You can add multiple email addresses to your github account and the commits can be signed by any of them, but I think they have to be real (so they can be verified). So I suggest you create a disposable gmail (or similar) email address, add it to your github account then update the commits. Also you can use the rebase (iirc) command to
Then use a |
@hardillb Thanks! Squashed all commits into one and updated the email. |
Thanks @alexk111 Has anyone else reviewed these translations? We don't have the ability to do that ourselves, for obvious reasons. |
@knolleary I mentioned the PR here. Maybe the topic starter or someone else will review it. I'm also working on a custom NR distro for Russian-speaking users. Hopefully this will bring some feedback on the text quality :) |
@alexk111 well, if you know any other native Russian-speakers who wouldn't mind reading through just to spot any typos, that would help. I will add a comment to the discourse thread as well. |
@knolleary Ok. Thanks |
Coverage decreased (-0.02%) to 77.317% when pulling c9f1b6523d1ba4918e2d3445a60e7e2a34542b19 on alexk111:ru-locale into f72903c on node-red:dev. |
@knolleary fyi, the locale is used in a software I made on top of node-red (botodrom.com). it's not open to a wider audience yet, but already has a few Russian-speaking beta users, so you might consider merging it. I'll also keep the locale updated with the new features and nr/core nodes changes :) |
Hi - sounds good. Is there any way we can get a 2nd opinion / feedback to verify they all make sense ? Would one of your beta users like to comment here please ? |
They are not GH citizens and such a request will be irrelevant for them :( As soon as I find a user familiar with GH, I'll definitely ask them to leave a comment here :) |
hi @alexk111 I think you will need to rebase this off latest dev so we can see the actual changes again - I did ask on the discourse forum for help - https://discourse.nodered.org/t/any-russian-speaking-users/34398 - and looks like there may be some volunteers - but we need to re-tidy this up so they can see just the changes... - Thanks |
Hi @dceejay. Updated the locale files with the recent changes, and rebased it onto upstream/master. |
Squashed into one commit to simplify the review: 060f22c |
@dceejay Please confirm if checking the commit for typos would be enough? Convincing others to install another NR instance from a GH branch looks like a non trivial task. |
Hi yes - we just need someone other than you to read through the https://github.com/node-red/node-red/pull/2531/files looking at the ones with the translations in and to check they make sense - both spelling and correct terminology if possible. |
Ok, got it. Thanks for the clarification! |
Hi @dceejay Thanks for merging the pr! Surely will keep the locale updated. |
thanks - - we are likely to push out v1.2.4 very shortly - so if you can fix that one file asap that would be great. |
Proposed changes
Adds Russian Locale for:
Checklist
grunt
to verify the unit tests passOnly
.json
and.html
files are added/updated, so no unit tests needed here.