Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian Locale #2531

Merged
merged 1 commit into from Nov 12, 2020
Merged

Add Russian Locale #2531

merged 1 commit into from Nov 12, 2020

Conversation

alexk111
Copy link
Contributor

@alexk111 alexk111 commented Apr 5, 2020

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Adds Russian Locale for:

  • Editor (UI, JSONata, tips)
  • Runtime
  • Core nodes (messages, help files)

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Only .json and .html files are added/updated, so no unit tests needed here.

@jsf-clabot
Copy link

jsf-clabot commented Apr 5, 2020

CLA assistant check
All committers have signed the CLA.

@alexk111
Copy link
Contributor Author

alexk111 commented Apr 5, 2020

Clabot states "CLA: not signed yet", however it should be. When I click the badge it opens the CLA page with "You have signed the CLA for node-red/node-red" at the top.

@hardillb
Copy link
Member

hardillb commented Apr 5, 2020

The usual reasons for this is that the commits have an email address that is not linked to your github account.

@alexk111
Copy link
Contributor Author

alexk111 commented Apr 5, 2020

What are the options to fix it? I use GitHub's @users.noreply.github.com no-reply email for commits and for signing CLA I used a private email.

@hardillb
Copy link
Member

hardillb commented Apr 5, 2020

You can add multiple email addresses to your github account and the commits can be signed by any of them, but I think they have to be real (so they can be verified). So I suggest you create a disposable gmail (or similar) email address, add it to your github account then update the commits.

Also you can use the rebase (iirc) command to

  1. compress all the commits into one
  2. change the email address on that commit

Then use a --force push to update your fork and it should be reflected here.

@alexk111
Copy link
Contributor Author

alexk111 commented Apr 6, 2020

@hardillb Thanks! Squashed all commits into one and updated the email.

@knolleary
Copy link
Member

Thanks @alexk111

Has anyone else reviewed these translations? We don't have the ability to do that ourselves, for obvious reasons.

@alexk111
Copy link
Contributor Author

alexk111 commented Apr 6, 2020

@knolleary I mentioned the PR here. Maybe the topic starter or someone else will review it. I'm also working on a custom NR distro for Russian-speaking users. Hopefully this will bring some feedback on the text quality :)

@knolleary
Copy link
Member

@alexk111 well, if you know any other native Russian-speakers who wouldn't mind reading through just to spot any typos, that would help. I will add a comment to the discourse thread as well.

@alexk111
Copy link
Contributor Author

alexk111 commented Apr 6, 2020

@knolleary Ok. Thanks

@knolleary knolleary added this to the 1.2 milestone Jun 29, 2020
@coveralls
Copy link

coveralls commented Jul 5, 2020

Coverage Status

Coverage decreased (-0.02%) to 77.317% when pulling c9f1b6523d1ba4918e2d3445a60e7e2a34542b19 on alexk111:ru-locale into f72903c on node-red:dev.

@alexk111
Copy link
Contributor Author

@knolleary fyi, the locale is used in a software I made on top of node-red (botodrom.com). it's not open to a wider audience yet, but already has a few Russian-speaking beta users, so you might consider merging it. I'll also keep the locale updated with the new features and nr/core nodes changes :)

@dceejay
Copy link
Member

dceejay commented Oct 16, 2020

Hi - sounds good. Is there any way we can get a 2nd opinion / feedback to verify they all make sense ? Would one of your beta users like to comment here please ?

@alexk111
Copy link
Contributor Author

They are not GH citizens and such a request will be irrelevant for them :( As soon as I find a user familiar with GH, I'll definitely ask them to leave a comment here :)

@dceejay
Copy link
Member

dceejay commented Oct 18, 2020

hi @alexk111 I think you will need to rebase this off latest dev so we can see the actual changes again - I did ask on the discourse forum for help - https://discourse.nodered.org/t/any-russian-speaking-users/34398 - and looks like there may be some volunteers - but we need to re-tidy this up so they can see just the changes... - Thanks
(or maybe you can DM them)

@alexk111
Copy link
Contributor Author

Hi @dceejay. Updated the locale files with the recent changes, and rebased it onto upstream/master.

@alexk111
Copy link
Contributor Author

alexk111 commented Oct 29, 2020

Squashed into one commit to simplify the review: 060f22c

@alexk111
Copy link
Contributor Author

@dceejay Please confirm if checking the commit for typos would be enough? Convincing others to install another NR instance from a GH branch looks like a non trivial task.

@dceejay
Copy link
Member

dceejay commented Oct 29, 2020

Hi yes - we just need someone other than you to read through the https://github.com/node-red/node-red/pull/2531/files looking at the ones with the translations in and to check they make sense - both spelling and correct terminology if possible.
And to either add comments or offer suggestions or say it is all ok.

@alexk111
Copy link
Contributor Author

Ok, got it. Thanks for the clarification!

@alexk111
Copy link
Contributor Author

@dceejay dceejay changed the base branch from dev to master November 12, 2020 17:00
@dceejay dceejay merged commit 4023ab3 into node-red:master Nov 12, 2020
@dceejay
Copy link
Member

dceejay commented Nov 12, 2020

Hi @alexk11
Finally - we get to merge it ! thanks for being so patient... Well done !

Note in 1.2.3 we did add a couple more message you will need to add - editor json file - see 2c6cda1

We will add you to the cc list to try to alert you when we make changes.

@alexk111
Copy link
Contributor Author

Hi @dceejay

Thanks for merging the pr! Surely will keep the locale updated.

@dceejay
Copy link
Member

dceejay commented Nov 16, 2020

thanks - - we are likely to push out v1.2.4 very shortly - so if you can fix that one file asap that would be great.

@alexk111
Copy link
Contributor Author

@dceejay Done in #2761

@alexk111 alexk111 deleted the ru-locale branch November 16, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants