Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info text of Function node #2714

Merged

Conversation

HiroyasuNishiyama
Copy link
Member

@HiroyasuNishiyama HiroyasuNishiyama commented Oct 6, 2020

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Setup code has been changed so that node.send can be used.
Since it is executed during the initialization process, the following nodes may not be able to receive the message.
This PR adds a note of caution about this.
Similarly, description about return value of setup process was added.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit 1edf5ac into node-red:dev Oct 6, 2020
@HiroyasuNishiyama HiroyasuNishiyama deleted the update-function-node-help-text branch February 12, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants