SPLIT Join node - support for msg.resetTimeout …

[magma1447]

… to restore original timeout

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Proposed changes

Adds support for the join node to reset its timer to the original value, by using an input key with the message. Similar to how it already handles msg.complete and msg.reset. I chose the name msg.resetTimeout.

This is a minor patch and I also created this forum thread.

Checklist

• I have read the contribution guidelines
• For non-bugfix PRs, I have discussed this change on the forum/slack team.
• I have run grunt to verify the unit tests pass
• I have added suitable unit tests to cover the new/changed functionality

[dceejay]

is resetTimeout the best / most obvious name ? To my mind reset may indicate clearing the timeout. Should it be restartTimeout or something ? thoughts ?

[dceejay]

I think the msg.resetTimeout property would be better mentioned as part of this line, as you have to have set a timeout in order to reset / extend it.

[magma1447]

@dceejay Since this isn't really my playing field, I followed both your advises. Regarding the name, I totally agree that restartTimeout is a better name than resetTimeout.

Regarding the documentation change I am not sure I find it more readable. But I also believe that you have much more experience with how Node-red and other nodes look, so in my opinion, your word has a lot of weight here. And to be honest, I don't care too much about the details, I am just happy if the feature I wish to use makes it into mainstream.

I do want to make as good job as possible though. I hope I am doing decently, because I am not too used to work with big projects like this, and even pull requests at GitHub and so forth. If I am doing something wrong, feel free to inform me so that I can learn.

[dceejay]

looking good so far :-)

[dceejay]

I'm happy for this to be merged

[coveralls]

Coverage decreased (-0.03%) to 67.634% when pulling f20565f on magma1447:dev into f1e7ec0 on node-red:dev.

[knolleary]

Thanks @magma1447 - this will be in the 2.1 release.

I have made a small update to the help text and added a unit test for the functionality here: ec27e19