Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to show link target when selected #3267

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

If the target of the Link node exists in another tab, selecting the virtual node will move to the tab of target node, but not the target node is not shown.
This fix show the target node after moving tab if there is only one target node in target tab.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.37% when pulling 7e7f481 on node-red-hitachi:fix-link-target-select into 3e0f080 on node-red:master.

@knolleary knolleary merged commit 279fcb7 into node-red:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants