Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tab hide button icon to an eye and add search option #3282

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

knolleary
Copy link
Member

  • New feature (non-breaking change which adds functionality)

This is technically a new feature that addresses a usability concern with the hide-tabs feature. I propose to include this in 2.1.4 rather than wait two months for 2.2.0.

As such, want to get sign-off from @dceejay as this is an exception to our normal way of working.

This PR improves the workflow around hiding tabs a bit. Specifically:

  • the icon is changed from the xto by the eye icon. Repeated feedback told us users felt the x implied they were deleting the tab rather than hiding. Changing the icon to the more benign eye is less alarming and more related to visibility rather than deletion.

  • moreso, when you hover on the tab the icon is the open eye. When you hover over the eye it closes. This also helps reinforce the purpose of the button.

  • The tab dropdown menu has a new option at the top if you have hidden flows that tells you how many hidden tabs there are. Clicking on this option opens the search dialog which will list the hidden flows.

    image

I think this is a much needed improvement to the hide flows workflow.

@dceejay
Copy link
Member

dceejay commented Dec 1, 2021

👍 from me. I would classify the icon change as a bug fix so worthy of release. The search option while yes an extra is only a small extra and fixed usability. The first outweighs the second by a wide margin imho.

@coveralls
Copy link

coveralls commented Dec 1, 2021

Coverage Status

Coverage remained the same at 67.363% when pulling a824b69 on tab-buttons into d9f976b on master.

@knolleary knolleary merged commit 800006d into master Dec 2, 2021
@knolleary knolleary deleted the tab-buttons branch December 2, 2021 09:29
@kazuhitoyokoi kazuhitoyokoi mentioned this pull request Dec 17, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants