New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hide icon in tour guide #3301

Merged

knolleary merged 1 commit into node-red:master from kazuhitoyokoi:master-fixwelcometour

Dec 17, 2021

Member

kazuhitoyokoi commented Dec 17, 2021

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

In the pull request, #3282, the hide icon was changed from x to the eye icon. But the tour guide still uses the x icon.

Therefore, I changed it to the eye icon by the pull request.

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run grunt to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          Fix hide button icon in tour guide

8df630a

Member

knolleary commented Dec 17, 2021

😢

Well spotted

knolleary merged commit 4ee4d32 into node-red:master

coveralls commented Dec 17, 2021

Coverage decreased (-0.007%) to 67.356% when pulling 8df630a on kazuhitoyokoi:master-fixwelcometour into 173e751 on node-red:master.

Member Author

kazuhitoyokoi commented Dec 17, 2021

@knolleary Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment