Subflow: Add labels to OUTPUT nodes

[ralphwetzel]

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Proposed changes

Subflow: Add labels to OUTPUT nodes

Checklist

• I have read the contribution guidelines
• For non-bugfix PRs, I have discussed this change on the forum/slack team.
• I have run grunt to verify the unit tests pass
• I have added suitable unit tests to cover the new/changed functionality

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ ralphwetzel (28f9168, eb1b8b5)

[knolleary]

Looks good. If I'm going to be very picky, in your screenshot, the left-hand text on Output 3 and 4 is not vertically aligned in the same way as Output 1 and 2 are.

[coveralls]

Coverage remained the same at 67.27% when pulling eb1b8b5 on ralphwetzel:dev into 81a4fe5 on node-red:dev.

[knolleary]

I'm going to merge this with some tweaks applied to resolve the vertical alignment.

Thanks for the contribution!

[ralphwetzel]

Hi Nick!
You're right. That was a deliberated design decision.
For single line labels (or the case without label), I sticked to the layout of the given Output node.
As soon as there's enough vertical space (beginning w/ a two line name), I centered the number and the port - which looked better to me.

3 & 5 show my approach - 1, 2 & 4 are based on the original layout.

Feel free to adapt this as appropriate.
R.

[knolleary]

Thanks for the comment. On balance, it looked odd to me for the alignment to not match. I've merged #3370 that keeps them all aligned. We can of course iterate in the future. 👍🏻