Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xml-crypto dependency #465

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Conversation

mans0954
Copy link
Contributor

  • Bump xml-crypto from 1.4.0 to 1.5.3
  • Include package-lock.json in repo

May possibly help with #456 ?

@cjbarth
Copy link
Collaborator

cjbarth commented Oct 16, 2020

@mans0954 , how would this help with #456? It seems that #465 is reporting that moving to v1.5.3 is what caused the problem in the first place. Unfortunately neither @yj188 nor @Harsha3878 provided a clear reproduction or a test that can be used to figure out what is going on.

@mans0954
Copy link
Contributor Author

@mans0954 , how would this help with #456? It seems that #465 is reporting that moving to v1.5.3 is what caused the problem in the first place. Unfortunately neither @yj188 nor @Harsha3878 provided a clear reproduction or a test that can be used to figure out what is going on.

The test pass with v1.5.3 when I run them - adding package-lock.json should ensure that we're all using the same sub-dependencies. I have no specific reason to think that users having different sub-dependencies installed is the issue in #465 - it just eliminates one possibility.

@mans0954 mans0954 merged commit 69c19b8 into master Oct 16, 2020
@mans0954 mans0954 deleted the csh-issue-456-xml-crypto-upgrade branch October 16, 2020 14:19
@cjbarth cjbarth added the dependencies Pull requests that update a dependency file label Sep 10, 2022
@cjbarth cjbarth changed the title Upgrade xml-crypto dependancy Upgrade xml-crypto dependency Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants