Prepare for 1.0

[bjrmatos]

The plan (discussed here):

• [deprecate] sig.loadSignature (at least from the public API).
• [new behaviour] checkSignature(String: xmlDocument, [String: externalSignatureXmlDocument]) will search and validate only the first signature found (a cool feature would be let the user to validate a specific signature, vía a XPath expression).
• [new feature] checkAllSignatures(String: xmlDocument, [String: externalSignatureXmlDocument]) will validate all signatures found (by default it will search inside the document for all instances of and validate all instances accordingly. if externalSignatureXmlDocument is specified it will search inside the external document).
• bring it back the condition: //*[local-name(.)='SignedInfo']/*[local-name(.)='Reference' and namespace-uri(.)='http://www.w3.org/2000/09/xmldsig#'] (removed here) to ensure a well formed xml document.. it will be ok since we have all the information that we need (namespaces) in the xml document node.
• both checkSignature and checkAllSignatures must support the externalSignatureXmlDocument param for external signatures.
• [refactor] adapt current tests
• [fix/improve] travis build (seems like it is broken since some time ago)
• [add] debug module for logging in development
• [remove] hacky workaround in this commits if more information is not provided here

🎉 The user wont need to specify the signature manually, xml-crypto will do it and will support multiple signature validation. 🎉

[bjrmatos]

i will post here if i find more improvements

[bjrmatos]

added a task to improve travis build

[bjrmatos]

added a task to use debug module for logging useful information in development

[bjrmatos]

fixed travis builds in fbb8dac

[fcorneli]

Is it possible to tag each release properly?

[bjrmatos]

@fcorneli sure! I will do it :)

[bjrmatos]

@yaronn can you enable the Travis webhook again? would be great to have the results of travis builds in PRs again :)

[yaronn]

where do I enable it? "build push" and "build pull requests" are already on
in the travis project. maybe its in the yml? or you can also create a
travis project with your name.

On Thu, Oct 15, 2015 at 7:33 AM, BJR Matos notifications@github.com wrote:

@yaronn https://github.com/yaronn can you enable the Travis webhook
again? would be great to have results of travis builds in PRs again :)

—
Reply to this email directly or view it on GitHub
#66 (comment).

I'm on Twitter (@YaronNaveh http://twitter.com/#!/YaronNaveh)

[bjrmatos]

can you look at the repository settings and confirm that travis is there?

screenshot from another repository:

[yaronn]

yes, it's there exactly as in the picture.

On Sat, Oct 17, 2015 at 10:42 PM, BJR Matos notifications@github.com
wrote:

can you look at the repository settings and confirm that travis is there?

screenshot from another repository:

[image: captura de pantalla 2015-10-17 a las 2 39 03 p m]
https://cloud.githubusercontent.com/assets/4262050/10560862/2f506d8e-74dd-11e5-93d3-116b52ef9900.png

—
Reply to this email directly or view it on GitHub
#66 (comment).

I'm on Twitter (@YaronNaveh http://twitter.com/#!/YaronNaveh)

[bjrmatos]

added a task to remove the code added here if more info is not provided.

[LoneRifle]

Closed as stale, we're now at versions beyond 1.0.