Scheduling jobs in the past

[santigimeno]

Before releasing 1.0.0 I would like to discuss if we should change the behavior when scheduling jobs in the past. The current behavior is that the job gets executed immediately.

My position is that we should not allow scheduling a job in the past, and that if somebody wants to execute something immediately, should just execute the task right away, without using node-schedule.

@davisford raised some valid points for keeping the functionality as it is. See: #151 for the discussion

cc/ @tejasmanohar @jonhester

[tejasmanohar]

Yeah, I don't like the idea of allowing jobs to be scheduled in the past. that could be prevented in the validation similar to the one we have a // TODO in the code right now for (see #108 but this one also for date-based scheduling).

[tejasmanohar]

Hm, I'm thinking of adding this back and releasing a major version change (semver). Thoughts, @santigimeno? I don't see a legitimate reason for node-schedule to run something immediately, even for tests- sounds like that should be handled with Date manipulation, sinon fake timers, or just testing the actual function that's being run by a job rather than the job scheduling itself.

[santigimeno]

@tejasmanohar I tend to agree with you. I just hope it doesn't break many applications, but probably the only way to know is having a new release out and wait for bug reports.

BTW what are your plans for this major release. I think you should open an issue to discuss what should be in form the dev branch.

[santigimeno]

Version 1.0.0 disallows for scheduling jobs in the past