Jobs don't fire due to leap year

[albertdatui]

There is a bug in cron-parser library.
I suspect that it is due to the leap year.

Here is the snippet of the error code.

[santigimeno]

I can confirm these errors are happening. Will look into them. Thanks for reporting!

[JosMarRivera]

+1

[fenwick67]

This bit me today (well, sometime within the last week or so).

This may be a duplicate of #172.

[JamCode]

+1

[zaikin-andrew]

+1

[ericsandine]

👍

var time = '00 41 11 * * 1-5';
Node: 0.12.7

[santigimeno]

Hey guys, can you check if the changes in #233 fix the issue for you? Thanks!

[adityabansod]

+1, ran in to this today

[corbanb]

IS there a fix for today then? I updated to 0.6.0.

[GermanBluefox]

I use node-schedule in my project. It is about 1000 people who use it. They all can't control heating, light and so on. I am interesting in solution too.

[tejasmanohar]

#233 (comment)

[santigimeno]

Hi all. I understand this issue is important for all. I plan releasing a 1.0.0 release soon (soon meaning when I/we can). In the meantime, it would really help if you could try the great fix from @albertdatui in #233 and provide feedback. Also, as @tejasmanohar said here #233 (comment), you can always add the branch from @albertdatui to your package.json to include the fix in your project. Thanks

[fenwick67]

I'm trying out the @albertdatui branch... it seems to be working for me.

[KevinC0]

@albertdatui branch is also working properly for me. In package.json: "node-schedule": "git://github.com/albertdatui/node-schedule.git#bugFixLeapYear"

[wwgc]

+1

[pickworth]

+1

same issue here

[vwatson]

+1

[ivands]

+1
i'm getting this error once a day.
Please fix this.
It's unusable right now.

[tejasmanohar]

this is a semver major change. @santigimeno suggests grouping it w/ the other 1.0 changes, which I stand by. in the meantime, see-

• Jobs don't fire due to leap year #225 (comment)
• Bug fix leap year #225 #233 (comment)

and definitely do not comment here or open additional issues unless you've read the above

[holm]

I deployed the branch from the pull request last night, and while there are no errors now, it also doesn't seem like it is firing any crons now.

[tejasmanohar]

@holm Can you provide an example we can run to replicate? Maybe you can use sinon fake timers? Small, isolated- separate from all your business logic and so forth.

[holm]

Absolutely. Let me look into a bit more and see what I can find and come up with a testcase.

[tejasmanohar]

Thanks! Next few days are super busy 😓 so no promises, but a reproducible test case makes debugging this 100x easier (and more reasonable) for anyone who'd like to attempt it.

[santigimeno]

@doronMendelson That's great news :)

[KevinC0]

I have been using the @albertdatui branch for 11 hours now. I thought it tackled 100% of my issue, however, I discovered this morning a strange behavior every hour between :45 and :00.

var j = schedule.scheduleJob('*/2 * * * *', function(){

https://www.dropbox.com/s/vxpy5die0btlqhc/Capture%20d%27%C3%A9cran%202016-02-01%2010.23.31.png?dl=0

I still have to investigate but it seems related.

[santigimeno]

@KevinC0 Ok just let us know if you find something. FYI, I've run some tests using your cron expression and sinon and it works correctly.

[zettam]

Any solutions so far?

[holm]

I have tried to reproduce the problem on my mac, but I can only reproduce on our servers. On our servers all the jobs fire immediately when started, and then never after that.

[santigimeno]

@holm Thanks for the info. Can you reproduce it consistently on your servers? If that's the case, can you add these lines:

  console.log('runOnDate >>>>>>>>>>>>>>>>>>>>>>>>>');
  console.log('now: ' + new Date(now));
  console.log('then: ' + new Date(then));
  console.log('runOnDate <<<<<<<<<<<<<<<<<<<<<<<<<');

To the runOnDate function here: https://github.com/albertdatui/node-schedule/blob/bugFixLeapYear/lib/schedule.js#L366, just before

if (then < now) {
    process.nextTick(job);
    return null;
  }

And paste the output?

[holm]

Alright, it seems the node-schedule package didn't update properly on the servers, even though the shrinkwrap file is fine and it works on Travis. I suspect it is a problem with npm@3.5, which has been giving us a bit of grief.

Sorry for the smoke on this, I think you should go ahead and release.

[santigimeno]

@holm Thanks for the feedback! Regarding the npm issue. We have avoided upgrading to npm@3 because of some weird behaviour and are using npm@2 everywhere.

[santigimeno]

Update regarding 1.0.0. Here https://github.com/node-schedule/node-schedule/tree/v1.0-pre is the code I hopefully will be publishing this evening as 1.0.0. It's just the code from #233 plus removing a functionality that was scheduled some time ago for 1.0.0: #157. Any feedback would be appreciated. Thanks

[cybertim]

It's working again, thank goodness 👍

wget https://github.com/node-schedule/node-schedule/archive/v1.0-pre.tar.gz
npm uninstall node-schedule
npm install v1.0-pre.tar.gz

[yossi-vexigo]

When the V1.0.0 need to released?
Thanks

[GermanBluefox]

npm install https://github.com/node-schedule/node-schedule/tarball/v1.0-pre

Works! Thank you.

[Jean-PhilippeD]

👍

[aaronchar]

👍

Thanks for the fix

[crissmoldovan]

Thanks guys :)

[gruzilla]

we changed our package.json to use the v1.0-pre repository and now everything works as it did 2015:

"node-schedule": "node-schedule/node-schedule#v1.0-pre"

thanks for the fix! 👍

[iwozzy]

+1

[andrewpuch]

+1

[ericsandine]

👍 Looks like it's working here

[isaackehle]

+1

[santigimeno]

Fixed in 2468fb7 and released as version 1.0.0.
Major props to @albertdatui for the excellent fix.

[ryanprinsloo]

Thanks for getting this sorted so quickly. You guys rock!

[mohitkhanna]

+1

[NiViktor]

Great work! Thanks!

[tejasmanohar]

Good job @santigimeno @albertdatui

[corbanb]

👍

[stephent]

I updated to 1.0.0, deployed and restarted my app, but my scheduled jobs are no longer firing (last execution was at 09:00 Jan 31 (Mountain Time). The schedule is as follows:

var job = schedule.scheduleJob('0 0,4,8,12,16,20 * * *', function(){...});

Is there something else I need to do to get things running again? Thanks!