Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

原先作为sessionId的依据为FromUserName,应考虑到多个商家可能出现用户id重复的问题 #29

Merged
merged 4 commits into from Aug 13, 2013

Conversation

realdog
Copy link

@realdog realdog commented Aug 13, 2013

原先作为sessionId的依据为FromUserName,考虑到多个商家可能出现用户id重复的问题,修改为 ToUserName + ":" + FromUse...rName 比较适合

var openid = message.FromUserName;
var userOpenid = message.FromUserName;
var serviceOpenid = message.ToUserName;
var _str = serviceOpenid + ":" + userOpenid;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用hash吧?

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling a23bf6e on realdog:master into 8b593b1 on node-webot:master.

@@ -138,7 +138,13 @@ var respond = function (handler) {
if (req.sessionStore) {
var storage = req.sessionStore;
var _end = res.end;
var openid = message.FromUserName;
var userOpenid = message.FromUserName;
var serviceOpenid = message.ToUserName;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进还是不对的。

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4fb4e4e on realdog:master into 8b593b1 on node-webot:master.

var openid = message.FromUserName;
var userOpenid = message.FromUserName;
var SPOpenid = message.ToUserName;
var mixId = SPOpenid + ":" + userOpenid;
res.end = function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var openid = message.FromUserName + ':' + message.ToUserName;

只改这一句就好了

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2df6fbd on realdog:master into 8b593b1 on node-webot:master.

JacksonTian added a commit that referenced this pull request Aug 13, 2013
原先作为sessionId的依据为FromUserName,应考虑到多个商家可能出现用户id重复的问题
@JacksonTian JacksonTian merged commit 1c9f665 into node-webot:master Aug 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants