Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

原先作为sessionId的依据为FromUserName，应考虑到多个商家可能出现用户id重复的问题 #29

Merged
merged 4 commits into from
Aug 13, 2013
Merged

原先作为sessionId的依据为FromUserName，应考虑到多个商家可能出现用户id重复的问题 #29

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57cc1cd
原先作为sessionId的依据为FromUserName，考虑到多个商家可能出现，修改为 ToUserName + ":" + From…
Aug 13, 2013
a23bf6e
据说某人没测试导致一个没声明的变量，以及缩进格式错误
Aug 13, 2013
4fb4e4e
某人觉得md5运算的块要单独提出来，后来又提到其实不做md5也一样，另外的某人一琢磨也对，就提交了
Aug 13, 2013
2df6fbd
将mixId修改为openid
Aug 13, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/wechat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,13 @@ var respond = function (handler) {
if (req.sessionStore) {
var storage = req.sessionStore;
var _end = res.end;
var openid = message.FromUserName;
var userOpenid = message.FromUserName;
var serviceOpenid = message.ToUserName;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进也有问题

var _str = serviceOpenid + ":" + userOpenid;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用hash吧？

var _hash = crypto.createHash("md5");
_hash.update(_str);
var _hashmsg = hash.digest('hex');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的hash未定义。测试都broken了

var hashid = _hashmsg.toString();
res.end = function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

var openid = message.FromUserName + ':' + message.ToUserName;

只改这一句就好了

_end.apply(res, arguments);
if (req.wxsession) {
Expand Down Expand Up @@ -166,12 +172,12 @@ var respond = function (handler) {
res.reply.apply(res, arguments);
};

storage.get(openid, function (err, session) {
storage.get(hashid, function (err, session) {
if (!session) {
req.wxsession = new Session(openid, req);
req.wxsession = new Session(hashid, req);
req.wxsession.cookie = req.session.cookie;
} else {
req.wxsession = new Session(openid, req, session);
req.wxsession = new Session(hashid, req, session);
}
done();
});
Expand Down