Tape tests #63
Closed
Tape tests #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d missing audio lib; in general, i don't think we can avoid supporting audio here since there's no media constraint to say "i don't send or receive audio".
…objects as well as updated the interface of peerconnection to include addstream and removestream
…ed criteria to test to allow for the test to verify that the stream can be relayed to another connection
…ream objects into AddStream() and RemoveStream()
…the tests can run and finish now.
… way they add and remove their child objects
Fix wrong URL
Remove `depot_tools` prereq, we do that now.
Add notes about libjingle prereqs.
Fix streamtest by updating wrtc.js and adding /dist to static paths.
…lemented in underlying webrtc libjingle code
…g) and close connections at completion of test
Updates to ice connection state names
wrong path in conditional for build script. fixes #34
Expose oniceconnectionstatechange on RTCPeerConnection
|
Could you rebase and pull again? |
|
Good call Alan. I'll either do that or just create a new branch from develop and add the tests. Either one of those would be much cleaner. Will close this PR and open another one in a few hours when I get to coding again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Alan,
OK - this is a bit of a monster in terms of commit count, but it should merge cleanly against the
developbranch as I've been ensuring this branch is always up-to-date with changes there.Essentially - this brings in the start of a suite of tests that should allow us to bring in CI into the mix - which will be awesome! As per other node modules the tests can be invoked by running
npm test.If you have any questions, let me know :)
Cheers,
Damon.