Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to License of Python v2.0.1 #160

Closed
ockham opened this issue Feb 10, 2021 · 4 comments
Closed

Update to License of Python v2.0.1 #160

ockham opened this issue Feb 10, 2021 · 4 comments

Comments

@ockham
Copy link

ockham commented Feb 10, 2021

We've been notified by our automated license checker tool that argparse's License of Python v2 is incompatible with the license that we use -- the GPL.

Would you consider updating to the License of Python v2.0.1? The only difference seems like a minor technicality (but IANAL). As for earlier versions:

This is a free software license but is incompatible with the GNU GPL. The primary incompatibility is that this Python license is governed by the laws of the State of Virginia, in the USA, and the GPL does not permit this.

(from https://www.gnu.org/licenses/license-list.en.html#PythonOld)

@puzrin
Copy link
Member

puzrin commented Feb 10, 2021

See #159. I'm ok with any valid non-restrictive license.

  1. What exact SPDX name do you suggest? https://spdx.org/licenses/. We can't reinvent custom ones.
  2. https://spdx.org/licenses/Python-2.0.html - i don't see any GPL issues by current SPDX name.

Are you sure problem is really with license but not with your validator? Seems you confused license version and python version.

@puzrin
Copy link
Member

puzrin commented Feb 13, 2021

Closing as "no fix required, everything already ok".

@puzrin puzrin closed this as completed Feb 13, 2021
@ockham
Copy link
Author

ockham commented Feb 19, 2021

Hey, sorry for getting back to this only now. tl;dr Probably fine to leave closed, but SPDX isn't totally accurate.

I've done a bit more research and elaborated at WordPress/gutenberg#28890 (comment) and WordPress/gutenberg#28890 (comment).

I'll quote the relevant bits:

Unlike the Python-2.0 license at SPDX, argparse's LICENSE file doesn't contain the following part:

  1. This License Agreement shall be governed by and interpreted in all respects by the law of the State of Virginia, [...]

That part is found in the "CNRI OPEN SOURCE LICENSE AGREEMENT (for Python 1.6b1)" section. (I'm not even sure if that part is legally binding or just there for historic purposes.) Anyway, I think that that part is what is mentioned by the GNU project's license list as the reason for that license being GPL-incompatible:

This is a free software license but is incompatible with the GNU GPL. The primary incompatibility is that this Python license is governed by the laws of the State of Virginia, in the USA, and the GPL does not permit this.

Anyway, argparse's LICENSE has the following instead:

  1. This License Agreement shall be governed by the federal
    intellectual property law of the United States, including without
    limitation the federal copyright law, and, to the extent such
    U.S. federal law does not apply, by the law of the Commonwealth of
    Virginia, excluding Virginia's conflict of law provisions. [...]

Note that this is identical to what the GNU Project calls the Python-2.0.1 license (which unfortunately isn't an SPDX-listed license), and lists as GPL-compatible 🎉


[Ideally,] SPDX [sh]ould include Python-2.0.1, and argparse would set its package.json's license field to it.

  • We might want to file an issue/PR against SPDX' GitHub repo, and follow up on the issue I filed on argparse's.
  • We could then set the Python-2.0.1 as GPL compatible in our license checker.

For the time being, I was able to unblock our project.
I'll file an issue against SPDX once I find some time (for more legalese PRs).

@ockham
Copy link
Author

ockham commented Feb 19, 2021

I'll file an issue against SPDX once I find some time (for more legalese PRs).

Friday night GH issues: spdx/license-list-XML#1200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants