Port the tests to Mocha. And some of the missed PyYAML tests. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 30, 2012 23:42
Switch to Mocha and hide Node-specific APIs from tests, which does not need them.
It is intended to use as a framework for the tests, and it will contain all of the helpers, utilities, and other shared code.
added 10 commits
December 18, 2012 18:00
| var assert = require('assert'); | ||
| var jsyaml = require('../../lib/js-yaml'); | ||
| var _errors = require('../../lib/js-yaml/errors'); | ||
| var _functional = require('../support/functional'); |
There was a problem hiding this comment.
why these variables starts with _?
|
Can you please align var foo = require('foo');
var bar = require('bar');
var mooboo = require('mooo'); |
| var Context = require('./assert-paranoid-equal/context'); | ||
|
|
||
|
|
||
| function paranoidEqual(value1, value2) { |
|
Hm... Seems like Travis don't like shims. I do not exactly understand the reason of this build fail. |
|
Yeah. Seems it was Travis' bug. |
|
If you have no more remarks, it is ready to merge. |
ixti
added a commit
that referenced
this pull request
Dec 20, 2012
Port the tests to Mocha. And some of the missed PyYAML tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from PyYAML:
Marked as "unsupported":
Cuted off:
Added: