node-pre-gyp -> @mapbox/node-pre-gyp

[samuela]

The node-pre-gyp has been deprecated, moving to @mapbox/node-pre-gyp instead. See here and here for more info.

Built successfully and all tests pass.

[jmurzy]

How can we get this into the next v28-alpha release?

[jfirebaugh]

There was a breaking change in 1.0.0 that affects the GitHub action

no longer supporting node_pre_gyp_accessKeyId & node_pre_gyp_secretAccessKey, use AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY instead to authenticate against s3 for info, publish, and unpublish commands.

This code will need to be updated:

nodegit/.github/workflows/tests.yml

Lines 69 to 71 in bae468c

	node_pre_gyp_bucket: ${{ secrets.node_pre_gyp_bucket }}
	node_pre_gyp_accessKeyId: ${{ secrets.node_pre_gyp_accessKeyId }}
	node_pre_gyp_secretAccessKey: ${{ secrets.node_pre_gyp_secretAccessKey }}

And similarly for macOS and Windows.

[ianhattendorf]

Is node-pre-gyp causing issues for anyone right now? I understand it's deprecated, but we have quite a bit on our backlog so if it's not broken we'll prioritize other tasks over updating packages that are still functioning. Thanks for the PR though! It's just there's a good amount of verification necessary when touching the build system.

[samuela]

This was a while ago so I don't remember what is/was breaking, but node-pre-gyp has been deprecated for over a year now. Prioritization is ofc up to maintainers tho.

[ianhattendorf]

This was handled alongside #1897, but thanks for bringing this to our attention!