Use relative paths for dependencies #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gyp generates full paths where necessary
- keep generated .vcxproj files in the build directory
- don't set ObjectFile path to "$(IntDir)/%(RelativeDir)/",
because win_delay_hook has an absolute path in %(RelativeDir)%
which causes
MSB3191 Unable to create directory: The given path's format is not supported
(nodejs/node-gyp#732)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gyp generates full paths where necessary
keep generated .vcxproj files in the build directory
don't set ObjectFile path to "$(IntDir)/%(RelativeDir)/",
because win_delay_hook has an absolute path in %(RelativeDir)%
which causes
MSB3191 Unable to create directory: The given path's format is not supported
(Delay hook absolute path cannot be created error MSB3191: Unable to create directory: The given path's format is not supported nodejs/node-gyp#732)