Bump nan to v2 #702

johnhaley81 · 2015-09-06T17:18:32Z

No description provided.

ssreekanth · 2015-09-08T19:16:41Z

👍

tbranyen · 2015-09-14T13:03:09Z

saper · 2015-09-14T14:05:31Z

I think there's nothing node-specific in those failure - it's just a problem with OpenSSL (using clang on FreeBSD here):

../vendor/openssl/openssl/ssl/s3_clnt.c:3262:60: error: use of undeclared identifier 'EVP_PKT_EXP'

https://gist.github.com/01e3c98204e251e8b2d9

tbranyen · 2015-09-14T17:28:10Z

@saper we're locked to a copy of openssl that builds just fine using the compilers on Travis-CI, for some reason node-gyp isn't cooperating with it (not sure why it's even affecting it).

saper · 2015-09-14T22:12:41Z

This particular problem is worked around by #707. It can be applied to master independently.

tbranyen · 2015-09-14T22:23:02Z

@saper thanks so much for looking into this, I just rebased your work and changed our test matrix to use Node 4.0 (removing iojs) fingers crossed.

tbranyen · 2015-09-14T23:01:57Z

Awesome, looking great on Linux and OS X now. Back to the Windows drawing board :-p

saper · 2015-09-14T23:04:43Z

Awesome, looking great on Linux and OS X now. Back to the Windows drawing board :-p

I am still getting compilation errors, although unrelated to node 4.

tbranyen · 2015-09-14T23:07:54Z

@saper Ah I'm referring to the CI, we run Node 0.12 and Node 4.0 in Linux and OS X and both are passing ATM.

saper · 2015-09-14T23:25:33Z

On Mon, 14 Sep 2015, Tim Branyen wrote: @saper Ah I'm referring to the CI, we run Node 0.12 and Node 4.0 in Linux and OS X and both are passing ATM.

That does not mean things are good :) Check out generated `src/checkout_options.cc` around line 536 with empty conditionals... fix in #708

tbranyen · 2015-09-14T23:31:41Z

but it gives me a green check mark 😸

saper · 2015-09-15T14:37:56Z

https://github.com/saper/nodegit/tree/mynode my attempts to improve the build (esp. with AppVeyor)

saper · 2015-09-15T21:44:41Z

So Windows failures are caused by the wrong path of the Win32 "delay hook". I have posted nodejs/node-gyp#732 with description.

saper · 2015-09-16T00:27:23Z

After #717 got merged there, this PR causes note.js tests to fail:

1) Note "before each" hook for "can be created":
     Error: Reference 'refs/remotes/master/HEAD' not found
      at Error (native)

That... was hard.

saper · 2015-09-17T17:49:14Z

can you git clean -dxf and try again?

ChristianMurphy · 2015-09-17T18:02:59Z

I ran

git clean -dxf
npm install

on node 4.0 and got same error, checking on 4.1 now

EDIT:
Node 4.1 has same message

njj · 2015-09-17T18:19:05Z

Everything works for me by cloning this repo into my node_modules and manually running npm install inside the repo.

saper · 2015-09-17T18:21:39Z

On Thu, 17 Sep 2015, Nick wrote: Everything works for me by cloning this repo into my `node_modules` and manually running `npm install` inside the repo.

That's because node 4.0 version is not yet released.

ChristianMurphy · 2015-09-17T19:59:32Z

@saper @tbranyen
Okay when I clone nodegit using git and build, it builds correctly.
If I download latest using NPM from "nodegit/nodegit" and it tries to build from there, the build fails with the libssh2 error.

tbranyen · 2015-09-17T20:26:01Z

I'm not sure why that would be, maybe try specifying the latest SHA.

ChristianMurphy · 2015-09-17T20:29:41Z

I tried "nodegit/nodegit#60e3f2aff7be57afb8d76d5e9adbf0b2459a6232" as well same result

maxkorp · 2015-09-17T20:34:23Z

Ooh, do you have openssl-dev or whatever it's called installed? IIRC that's required to configure libssh2, which is what appears to be dying. I know it usually gets installed with most build-chains in ubuntu, but it's very plausible it didn't for you.

saper · 2015-09-17T20:36:53Z

I tried `"nodegit/nodegit#60e3f2aff7be57afb8d76d5e9adbf0b2459a6232"` as well same result

git fetching is very tricky to get right. I think npm gave up in fixing this.

maxkorp · 2015-09-17T20:38:13Z

@saper Really? I've used that to great success. That's unfortunate if so.

I know they have a lot of issues with build lifecycle with nodegit manually works around currently though, and that seems to just go in a loop of "so why do we need this". Don't think they gave up on that at least.

saper · 2015-09-17T20:46:58Z

@saper Really? I've used that to great success. That's unfortunate if so.

Check out jokes in the npm's CHANGELOG.md :) But seriously plain clone over git should work. I've got bitten by trying to use git URLs in the package.json for dependencies.

I know they have a lot of issues with build lifecycle with nodegit manually works around currently though, and that seems to just go in a loop of "so why do we need this". Don't think they gave up on that at least.

It is possible that it does not work since #715. I am still lost in the maze of our lifecycle scripts.

maxkorp · 2015-09-17T20:47:59Z

Yeah I've been shaving those down bit by bit as I get the chance. If I could find a good gypfile for libssh2, we could remove them almost entirely.

saper · 2015-09-17T20:56:23Z

Yeah I've been shaving those down bit by bit as I get the chance. If I could find a good gypfile for libssh2, we could remove them almost entirely.

You man to get rid of autoconf? Will be difficult, because gyp is not meant to replace it :(

maxkorp · 2015-09-17T20:59:44Z

Yeah, I know. Very unfortunate, really :/
I've found one or two that seem to work cross platform for smaller applications, but no idea how tested they are etc. We can't get rid of the lifecyclescirpts without getting rid of the autoconf, though.

ChristianMurphy · 2015-09-17T21:02:08Z

@maxkorp

you have openssl-dev or whatever it's called installed?

I have openssl, libssl-dev and libssh-dev installed my system.

ChristianMurphy · 2015-09-17T21:08:20Z

git fetching is very tricky to get right. I think npm gave up in fixing this.

@saper

I checked my file system and it appears that NPM did fetch the correct version of the code down.

I'm wondering if possibly pulling the code from Git using NPM might trigger the .npmignore instead of the .gitignore and leave out a file needed to build.

maxkorp · 2015-09-17T21:20:47Z

It will respect both the .gitignore AND the .npmignore, ignoring anything specified by either (but explicit includes from one, will not override excludes by the other). That said, that was never a problem before.
#715 may be related however.

saper · 2015-09-17T21:22:09Z

It will respect both the .gitignore AND the .npmignore, ignoring anything specified by either (but explicit includes from one, will not override excludes by the other). That said, that was never a problem before. #715 may be related however.

"npm install" called from the lifecycle script fails in so many beautiful ways... so I'd rather not do it again.

maxkorp · 2015-09-17T21:25:52Z

Oh totally. Not a fan either. Do note however that it was npm install --ignore-scripts which prevents anything from calling lifecyclescripts (blocking an infinite recursion)`. We can dig into this in the other issue if needed though. (if we can confirm that it is an issue)

saper · 2015-09-17T22:32:10Z

@ChristianMurphy can you try #726

npm install 'git://github.com/saper/nodegit#configurestays'

It lets me to go past the configure step.

Why the hell our beautiful code full of promises is unable to produce an error message
that configure is missing:

[nodegit] Configuring libssh2.
npm WARN unmet dependency /home/saper/node_modules/node-sass requires nan@'^2.0.8' but will load
npm WARN unmet dependency /home/saper/node_modules/nan,
npm WARN unmet dependency which is version 2.0.5
npm WARN unmet dependency /home/saper/node_modules/node-sass requires request@'^2.61.0' but will load
npm WARN unmet dependency /home/saper/node_modules/request,
npm WARN unmet dependency which is version 2.55.1
nodegit@0.4.1 nodegit
├── promisify-node@0.2.1
├── which-native-nodish@1.1.3 (find-parent-dir@0.3.0, nodegit-promise@1.0.2)
├── nodegit-promise@3.0.2 (asap@2.0.3)
├── fs-extra@0.18.4 (jsonfile@2.2.2, graceful-fs@3.0.8, rimraf@2.4.3)
├── node-pre-gyp@0.6.10
└── npm@2.14.3

Not to mention it would be nice to return an error code so that npm stops. Also #713.

ChristianMurphy · 2015-09-17T22:46:58Z

@saper installing from git://github.com/saper/nodegit#configurestays succeeded 🎉

saper · 2015-09-17T22:52:56Z

@saper installing from `git://github.com/saper/nodegit#configurestays` succeeded 🎉

I have merged the change, so now plain `git://github.com/nodegit/nodegit` should work.

ssreekanth · 2015-09-18T01:38:27Z

@saper Is the nodegit build working on windows now?

I tried installing from

nodegit/nodegit#330abdb21dc3619c495bb4e975563fab1561659d

but still failing on windows -

npm ERR! nodegit@0.4.1 install: `node lifecycleScripts/install`
npm ERR! Exit status 13

However, on Linux/OSX, it works fine.

saper · 2015-09-18T07:19:09Z

@ssreekanth This is means that the compilation failed. Do you get anything more than that? Error messages from the compiler?

ssreekanth · 2015-09-20T02:36:24Z

@saper These are the error messages I got -

[nodegit] Everything is ready to go, attempting compilation
[nodegit] Building native node module.
{ [Error: Command failed: C:\Windows\system32\cmd.exe /s /c "SET HOME=%HOME%\.atom-shell-gyp&&  C:\Users\sandbox\nodegit-test\node_modules\nodegit\node_modules\.bin\node-gyp rebuild --target=0.33.0  --dist-url=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist"
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\12.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\sandbox\nodegit-test\node_modules\nodegit\node_modules\node-gyp\lib\build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\sandbox\\nodegit-test\\node_modules\\nodegit\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=0.33.0" "--dist-url=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist"
gyp ERR! cwd C:\Users\sandbox\nodegit-test\node_modules\nodegit
gyp ERR! node -v v4.1.0
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
]
  killed: false,
  code: 1,
  signal: null,
  cmd: 'C:\\Windows\\system32\\cmd.exe /s /c "SET HOME=%HOME%\\.atom-shell-gyp&&  C:\\Users\\sandbox\\nodegit-test\\node_modules\\nodegit\\node_modules\\.bin\\node-gyp rebuild --target=0.33.0  --dist-url=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist"' }
undefined
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v4.1.0
npm ERR! npm  v2.14.3
npm ERR! code ELIFECYCLE

npm ERR! nodegit@0.4.1 install: `node lifecycleScripts/install`
npm ERR! Exit status 13
npm ERR!
npm ERR! Failed at the nodegit@0.4.1 install script 'node lifecycleScripts/install'.
npm ERR! This is most likely a problem with the nodegit package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node lifecycleScripts/install
npm ERR! You can get their info via:
npm ERR!     npm owner ls nodegit
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\sandbox\nodegit-test\npm-debug.log

And my package.json is

{
  "name": "Sample",
  "version": "1.0.0",
  "description": "",
  "main": "main.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "engines": {
    "atom-shell": "0.33.0",
    "electron": "0.33.0"
  },
  "dependencies": {
    "nodegit": "nodegit/nodegit#330abdb21dc3619c495bb4e975563fab1561659d"
  },
  "devDependencies": {
    "electron-prebuilt": "0.33.0",
    "electron-rebuild": "^1.0.0"
  }
}

saper · 2015-09-20T02:48:28Z

@ssreekanth Can you check if #729 fixes the issue.

ssreekanth · 2015-09-20T05:46:57Z

@saper it is still failing with #729 ..

[nodegit] Everything is ready to go, attempting compilation
[nodegit] Building native node module.
{ [Error: Command failed: C:\Windows\system32\cmd.exe /s /c "C:\Users\sandbox\nodegit-test\node_modules\nodegit\node_modules\.bin\node-gyp rebuild --target=0.33.0  --dist-url=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist"
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\12.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\sandbox\nodegit-test\node_modules\nodegit\node_modules\node-gyp\lib\build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\sandbox\\nodegit-test\\node_modules\\nodegit\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=0.33.0" "--dist-url=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist"
gyp ERR! cwd C:\Users\sandbox\nodegit-test\node_modules\nodegit
gyp ERR! node -v v4.1.0
gyp ERR! node-gyp -v v3.0.3
gyp ERR! not ok
]
  killed: false,
  code: 1,
  signal: null,
  cmd: 'C:\\Windows\\system32\\cmd.exe /s /c "C:\\Users\\sandbox\\nodegit-test\\node_modules\\nodegit\\node_modules\\.bin\\node-gyp rebuild --target=0.33.0  --dist-url=https://gh-contractor-zcbenz.s3.amazonaws.com/atom-shell/dist"' }
undefined
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "nodegit"
npm ERR! node v4.1.0
npm ERR! npm  v2.14.3
npm ERR! code ELIFECYCLE

npm ERR! nodegit@0.4.1 install: `node lifecycleScripts/install`
npm ERR! Exit status 13

deyhle · 2015-09-20T12:17:36Z

When will this be released to npm?

johnhaley81 · 2015-09-26T21:19:03Z

@deyhle it's out now as 0.5.0

This was referenced Sep 6, 2015

Update supported Node JS versions #674

Closed

Nodegit build fails with Electron 0.31.x / 0.32.x #686

Closed

This was referenced Sep 13, 2015

Not working properly on Node.js 4.0.0 #704

Closed

Packages that currently do not work with Node.js v4.0 [List] nodejs/node#2798

Closed

tbranyen force-pushed the bump-nan branch from fce057f to ab427b0 Compare September 14, 2015 22:22

saper mentioned this pull request Sep 15, 2015

Nodegit npm install error on FreeBSD 10 #690

Closed

tbranyen force-pushed the bump-nan branch from ab427b0 to 95e5339 Compare September 15, 2015 19:50

saper added this to the node 4.0 milestone Sep 16, 2015

saper added CPP Build labels Sep 16, 2015

saper mentioned this pull request Sep 16, 2015

Error: Reference 'refs/remotes/master/HEAD' not found in tests: "before each" hook for "can be created": #718

Open

John Haley added 5 commits September 16, 2015 13:20

Bump to nan v2

a5c6981

Fix wrapper

845bae1

Fix str_array_converter

e9dfe00

Fix build to work with nan v2

927b8e5

That... was hard.

Add iojs 3 to test matrix

bf7e15f

ssreekanth mentioned this pull request Oct 6, 2015

nodegit fails to build for Electron on Windows #738

Closed

Bump nan to v2 #702

Bump nan to v2 #702

Conversation

johnhaley81 commented Sep 6, 2015

ssreekanth commented Sep 8, 2015

tbranyen commented Sep 14, 2015

saper commented Sep 14, 2015

tbranyen commented Sep 14, 2015

saper commented Sep 14, 2015

tbranyen commented Sep 14, 2015

tbranyen commented Sep 14, 2015

saper commented Sep 14, 2015 via email

tbranyen commented Sep 14, 2015

saper commented Sep 14, 2015 via email

tbranyen commented Sep 14, 2015

saper commented Sep 15, 2015

saper commented Sep 15, 2015

saper commented Sep 16, 2015

saper commented Sep 17, 2015

ChristianMurphy commented Sep 17, 2015

njj commented Sep 17, 2015

saper commented Sep 17, 2015 via email

ChristianMurphy commented Sep 17, 2015

tbranyen commented Sep 17, 2015

ChristianMurphy commented Sep 17, 2015

maxkorp commented Sep 17, 2015

saper commented Sep 17, 2015 via email

maxkorp commented Sep 17, 2015

saper commented Sep 17, 2015 via email

maxkorp commented Sep 17, 2015

saper commented Sep 17, 2015 via email

maxkorp commented Sep 17, 2015

ChristianMurphy commented Sep 17, 2015

ChristianMurphy commented Sep 17, 2015

maxkorp commented Sep 17, 2015

saper commented Sep 17, 2015 via email

maxkorp commented Sep 17, 2015

saper commented Sep 17, 2015

ChristianMurphy commented Sep 17, 2015

saper commented Sep 17, 2015 via email

ssreekanth commented Sep 18, 2015

saper commented Sep 18, 2015

ssreekanth commented Sep 20, 2015

saper commented Sep 20, 2015

ssreekanth commented Sep 20, 2015

deyhle commented Sep 20, 2015

johnhaley81 commented Sep 26, 2015