Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatiron refactor #87

Merged
merged 64 commits into from Dec 7, 2011
Merged

Flatiron refactor #87

merged 64 commits into from Dec 7, 2011

Conversation

indexzero
Copy link
Member

Works with flatiron@0.1.4

@bmeck @mmalecki Please review and confirm all tests are passing.

… dependencies linked. Now to publish and update package.json(s)
@mmalecki
Copy link
Contributor

mmalecki commented Dec 6, 2011

Tests hang for me here:


➜  haibu git:(flatiron) npm test

> haibu@0.5.6-1 test /Users/maciej/dev/JavaScript/haibu
> sudo vows test/**/*-test.js --isolate --spec

Password:

♢ haibu/config

  When using the haibu config module
    ✓ it should have the correct methods set

Also, it doesn't merge into master cleanly, mind rebasing?

@pksunkara
Copy link

The same happens to me, though after a few more tests

… dependencies linked. Now to publish and update package.json(s)
…hrown in node@0.4.12 when attempting to pipe a bad tarball to `haibu.config.get("tar")`
indexzero added a commit that referenced this pull request Dec 7, 2011
@indexzero indexzero merged commit d6decd2 into master Dec 7, 2011
aenario pushed a commit to aenario/cozy-controller that referenced this pull request Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants