New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
being able to push client files without restarting the app #122
Comments
Not sure if that's even possible without monkey-patching node module system Also, maybe -- Maciej Maecki
|
He wants to upload files that change the source of the application, without restarting the process. |
yeah, anything in /public. What does 'jitsu apps update' do? |
I'm going to have to say that hot-loading code is generally a bad idea and bad application design. If there is a generic way to expose this functionality ( through a user-land module ), I'll consider adding support for the feature. |
I'm not talking about hot-loading server code. Just updating the static files your app serves (js, css etc.). That shouldn't require a back-end restart & I don't think that's bad application design. |
I was referring only to hot-reloading actual node code. If there are changes to the contents of your application, it will require a restart. We have no way of knowing if you are trying to modify static assets or node.js code. If anything, this will become a non-issue when we have zero-downtime deploys working. If you have a lot of static assets, you should be using a cloud storage file-system and linking your application to that. |
Zero-downtime deploys would solve the problem. However, it would create some unnecessary overhead when you're just need to push a simple CSS fix. |
Your application isn't bound to any one specific server. When new code is pushed, it's pushed to a new machine ( usually ), which means the old version of the application needs to be stopped, and the new one needs to be started. |
Understood! Thanks. |
"jitsu deploy" currently always restarts the app. You should be able to update your client files without restarting the app.
The text was updated successfully, but these errors were encountered: