Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

being able to push client files without restarting the app #122

Closed
louissmit opened this issue Nov 18, 2011 · 9 comments
Closed

being able to push client files without restarting the app #122

louissmit opened this issue Nov 18, 2011 · 9 comments

Comments

@louissmit
Copy link

"jitsu deploy" currently always restarts the app. You should be able to update your client files without restarting the app.

@mmalecki
Copy link
Contributor

Not sure if that's even possible without monkey-patching node module system
and that's something we definitely want to avoid.
Does your app take so long to start or do you store things in memory?

Also, maybe jitsu apps update is what you're looking for?

-- Maciej Maecki
18-11-2011 14:05 uytkownik "louissmit" <
reply@reply.github.com>
napisa:

"jitsu deploy" currently always restarts the app. You should be able to
update your client files without restarting the app.


Reply to this email directly or view it on GitHub:
#122

@Marak
Copy link
Contributor

Marak commented Nov 18, 2011

He wants to upload files that change the source of the application, without restarting the process.

@louissmit
Copy link
Author

yeah, anything in /public. What does 'jitsu apps update' do?

@Marak
Copy link
Contributor

Marak commented Mar 21, 2012

jitsu apps update is for updating configuration information about the application, like fields stored in the package.json ( subdomain, etc )

I'm going to have to say that hot-loading code is generally a bad idea and bad application design. jitsu isn't going to natively support this anytime soon.

If there is a generic way to expose this functionality ( through a user-land module ), I'll consider adding support for the feature.

@Marak Marak closed this as completed Mar 21, 2012
@louissmit
Copy link
Author

I'm not talking about hot-loading server code. Just updating the static files your app serves (js, css etc.). That shouldn't require a back-end restart & I don't think that's bad application design.

@Marak
Copy link
Contributor

Marak commented Mar 21, 2012

I was referring only to hot-reloading actual node code.

If there are changes to the contents of your application, it will require a restart. We have no way of knowing if you are trying to modify static assets or node.js code. If anything, this will become a non-issue when we have zero-downtime deploys working.

If you have a lot of static assets, you should be using a cloud storage file-system and linking your application to that.

@louissmit
Copy link
Author

Zero-downtime deploys would solve the problem. However, it would create some unnecessary overhead when you're just need to push a simple CSS fix.
So, out of curiosity, the Nodejitsu API doesn't allow to just do like a 'git push' to your instance? That way your new static assets would be used immediately but your node code will only be used on restart.

@Marak
Copy link
Contributor

Marak commented Mar 21, 2012

Your application isn't bound to any one specific server.

When new code is pushed, it's pushed to a new machine ( usually ), which means the old version of the application needs to be stopped, and the new one needs to be started.

@louissmit
Copy link
Author

Understood! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants