Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message on nonempty queue + fix child hanging on stdin #17

Merged
merged 3 commits into from
Apr 14, 2014
Merged

Improve message on nonempty queue + fix child hanging on stdin #17

merged 3 commits into from
Apr 14, 2014

Commits on Apr 14, 2014

  1. Add details to "non-empty queue on spawn exit" 

    Improve the error reported when the child process exits before the
whole queue is processed:
 - use assert.AssertionError instead of plain Error
 - fill actual and expected properties
 - include the description of items remaining in the queue
    Miroslav Bajtoš committed Apr 14, 2014
    Configuration menu
    Copy the full SHA
    6182690 View commit details
    Browse the repository at this point in the history

  2. Add details to "no data from child..." 

    Improve the error reported when there are not enough lines in the
child process output.
 - use assert.AssertionError instead of plain Error
 - fill actual and expected properties
 - include the description of items remaining in the queue
    Miroslav Bajtoš committed Apr 14, 2014
    Configuration menu
    Copy the full SHA
    915432e View commit details
    Browse the repository at this point in the history

  3. Add spawn.sendEof to close the stdin pipe 

    `spawn.sendEof` allows users to close child's process stdin stream
and let it know there are no more data coming.

This change enables testing of apps that are using inquirer,
as `inquirer.prompt()` calls `stdin.resume()` at some point,
which causes the app to block on input when the input stream is a pipe.
    Miroslav Bajtoš committed Apr 14, 2014
    Configuration menu
    Copy the full SHA
    5118400 View commit details
    Browse the repository at this point in the history