Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Buffer constructor: zero-fill in Node.js 8.0.0? #89

Closed
Trott opened this issue Mar 30, 2017 · 10 comments
Closed

Buffer constructor: zero-fill in Node.js 8.0.0? #89

Trott opened this issue Mar 30, 2017 · 10 comments

Comments

@Trott
Copy link
Member

Trott commented Mar 30, 2017

@nodejs/ctc Next vote that was started in the CTC meeting. If you are not listed below (or if your vote has changed or been recorded incorrectly), please comment! Thanks!

Should we zero-fill in Node.js 8.0.0?

YES: @jasnell, @Fishrock123, @ofrobots, @trevnorris, @mhdawson, @targos, @addaleax, @evanlucas, @cjihrig, @indutny, @thefourtheye, @bnoordhuis, @shigeki

NO: @mscdex, @ChALkeR, @misterdjules

ABSTAIN: @Trott @rvagg

MY VOTE DEPENDS ON WHETHER OR NOT WE BACKPORT AND/OR WHICH RELEASE LINES WE BACKPORT TO:

I'll open a separate issue for the question of whether we random-fill. If both pass and there's not consensus over which one to do, we'll have another vote.

@indutny
Copy link
Member

indutny commented Mar 30, 2017

YES

@Trott
Copy link
Member Author

Trott commented Mar 30, 2017

With 10 votes in favor, 2 opposed, and 1 abstention, this can be called. The result is: YES.

However, since this issue has only been open for two minutes, I'll leave this open for 24 hours, just in case someone wants to change their vote or their vote has been incorrectly recorded. I encourage people to continue to leave vote comments even though the vote seems decided. It's possible that someone may switch their vote, and then suddenly your additional vote makes all the difference.

@misterdjules
Copy link

My vote is no.

@rvagg
Copy link
Member

rvagg commented Mar 31, 2017

delayed abstain with a slight leaning to yes (i.e. +0)

@thefourtheye
Copy link

Yes

@bnoordhuis
Copy link
Member

YES

(I don't like to shout.)

@Mayhem93
Copy link

My vote is NO. What would be the purpose of Buffer.prototype.fill then?

@addaleax
Copy link
Member

What would be the purpose of Buffer.prototype.fill then?

Quick answer: Fill buffers that were allocated with Buffer.allocUnsafe(Slow), fill them with a different byte value, fill them with repeated instances of a string, only fill part of a buffer with a given value.

But I’d really recommend you to take discussions to nodejs/node#9531, this thread is specifically for CTC members voting, anything else is a bit off-topic…

@shigeki
Copy link

shigeki commented Mar 31, 2017

Yes

@Trott
Copy link
Member Author

Trott commented Mar 31, 2017

It's been the 24 hours I said I'd wait. This is definitely approved. Final vote count:

YES: 13

NO: 3

ABSTAIN: 2

(CTC members who did not vote or indicate they planned to abstain: 2)

Thanks, everyone!

@Trott Trott closed this as completed Mar 31, 2017
@Trott Trott removed the ctc-review label Apr 3, 2017
jasnell added a commit to nodejs/node that referenced this issue Apr 3, 2017
PR-URL: #12141
Ref: nodejs/CTC#89
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants