Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer of dynamic-modules-proposal repo into nodejs organization #231

Closed
guybedford opened this issue Sep 10, 2018 · 20 comments
Closed

transfer of dynamic-modules-proposal repo into nodejs organization #231

guybedford opened this issue Sep 10, 2018 · 20 comments

Comments

@guybedford
Copy link
Contributor

guybedford commented Sep 10, 2018

In the process of working on the Dynamic Modules specification at TC39, it has been deemed that like Web Assembly, the best home for a spec dedicated to Node concerns around modules should be the NodeJS organization.

We are working on some layering and editorial changes to make Dynamic Modules more easily implemented as a separate specification on top of ECMA262, so it will be even simpler/shorter than the existing spec text at https://guybedford.github.io/proposal-dynamic-modules/.

This proposal is part of the work of the modules working group, and as such ownership should be shared as this work continues to progress. We are currently in the process of collaborating on implementation.

@ljharb

This comment has been minimized.

@ljharb

This comment has been minimized.

@guybedford
Copy link
Contributor Author

@ljharb the stage 1 TC39 proposal is being withdrawn.

@guybedford
Copy link
Contributor Author

Ah, sure, no problem!

@bnb
Copy link
Contributor

bnb commented Sep 10, 2018

No issue from my POV. That said, would love to get more context on the decision from TC-39 if at all possible 😄

@Fishrock123
Copy link
Member

Shouldn't this be brought up to the modules team, and/or the spec collaboration team, instead of Admin?

@MylesBorins
Copy link
Member

Would also like some clarity as to why this should be a separate repo as opposed to a discussion in in modules or open-standards.

To be clear, not objecting, would just like more clarity

@bmeck
Copy link
Member

bmeck commented Sep 11, 2018

@MylesBorins probably as a place to put the work and create a specification I would imagine. A discussion thread is hard to manage if we have to deal with PRs and discussing of specific semantics of a document such as seems to be wanting to be produced here. I don't think such a spec text itself would be apt to live in either the modules or open-standards repository much like how proposals to other standards bodies generally have their own repositories.

@MylesBorins
Copy link
Member

Ah, I missed that the repo was initially in guy bedfords GitHub.

+1 to transfer it here. I think it would make sense to include a note or pointer from the open standards repo for discoverability

@guybedford
Copy link
Contributor Author

Shouldn't this be brought up to the modules team, and/or the spec collaboration team, instead of Admin?

@Fishrock123 this is more about the spec work itself needing a home repository for its development. Further discussion with the modules team / spec collaboration team can certainly happen as things develop.

I think it would make sense to include a note or pointer from the open standards repo for discoverability

Sure!

@joyeecheung
Copy link
Member

joyeecheung commented Sep 12, 2018

Not exactly specific to this request, but I personally prefer to transfer an existing repo with something concrete created beforehand instead of creating a new repo from scratch in this organization, unless the repo only serves as a place for discussions and there isn't anything of substance in the commit history. Mostly because it's unnecessary to wait for the request to go through before jumping into the work, it also gives us a chance to take a better look at the idea before making it semi-official.

@guybedford
Copy link
Contributor Author

@joyeecheung the existing repo is at https://github.com/guybedford/proposal-dynamic-modules, including spec text.

@guybedford
Copy link
Contributor Author

Any suggestions for moving this forward?

@joyeecheung
Copy link
Member

@guybedford You may be interested in looking at this a-bit-outdated (sorry) WIP guide on how to transfer a repo into the organization (please ignore the Travis part as we use the Travis app now).

@guybedford
Copy link
Contributor Author

Thanks @joyeecheung, I've added a code of conduct link to the project and verified the license.

I'd like to reiterate my request to transfer the proposal-dynamic-modules repo into the Node.js organization.

The reasoning is as described in the original post here (with some edits).

//cc @nodejs/community-committee @nodejs/tsc

@guybedford guybedford changed the title creation of new repository: dynamic-modules-spec transfer of dynamic-modules-proposal repo Oct 8, 2018
@guybedford guybedford changed the title transfer of dynamic-modules-proposal repo transfer of dynamic-modules-proposal repo into nodejs organization Oct 8, 2018
@Trott
Copy link
Member

Trott commented Oct 8, 2018

@guybedford You're seeking confirmation of administrative approval to move it, right? As a Member of @nodejs, I believe you have all the technical privieges you need to transfer it yourself. (Or am I mistaken?)

Anyway, as long as the particular requirements in Joyee's doc (CoC, License...) are met, I'm 👍 on transferring it to the org.

@richardlau
Copy link
Member

@guybedford You're seeking confirmation of administrative approval to move it, right? As a Member of @nodejs, I believe you have all the technical privieges you need to transfer it yourself. (Or am I mistaken?)

Anyway, as long as the particular requirements in Joyee's doc (CoC, License...) are met, I'm 👍 on transferring it to the org.

https://github.com/nodejs/admin/blob/master/GITHUB_ORG_MANGEMENT_POLICY.md#repositories says:

Any organization member may request the management of repositories within the
Node.js Foundation GitHub Organization by opening an issue in the
Node.js admin repository. The actions requested could be:

  • Creating a new repository
  • Deleting an existing repository
  • Archiving an existing repository
  • Transferring a repository into or out of the organization

Provided there are no objections from any TSC or CommComm members raised in
the issue, such requests are approved automatically after 72 hours. If any
objection is made, the request may be moved to a vote in each of the
Technical Steering and Community Committees. If either the TSC or CommComm
rejects the request, then the request is denied.

I guess the only question is whether for this issue the 72 hours started when it was opened or when it was clarified this is a transfer rather than the creation of a new repository.

@guybedford
Copy link
Contributor Author

@Trott thanks for clarifying - yes I'm exactly looking to confirm administrative approval on this. Good to know the permissions are already in place.

@richardlau much appreciated, that's exactly the policy link I was after as well.

@guybedford
Copy link
Contributor Author

Thanks all for the feedback here and help getting this through. I've completed the transfer at https://github.com/nodejs/dynamic-modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants