Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS 10.14 deprecation plan #3087

Closed
UlisesGascon opened this issue Nov 22, 2022 · 12 comments · Fixed by #3327
Closed

MacOS 10.14 deprecation plan #3087

UlisesGascon opened this issue Nov 22, 2022 · 12 comments · Fixed by #3327

Comments

@UlisesGascon
Copy link
Member

Checking the support for MacOs versions, seems like 10.x versions are deprecated. Should be plan the upgrade of the test machines using 10.x?

@AshCripps
Copy link
Member

Our minimum deployment target is set to 10.15 already but thats only for v18 and above so 10.14 is still supported by LTS lines still in support. I know we have a caveat that we can drop EOL systems at will but it might be worth waiting for a bit before dropping that.

firstly we need some more machines of later versions, we dont have any 12 or 13 machines to my knowledge nor do we have the capacity on the arm64 side for them. Intel should be fine due to the amount of space we have in orka.

@richardlau
Copy link
Member

It is worth discussing bumping the minimum deployment target for Node.js 20 (bearing in mind whatever we set will be it until the April 2026 End-of-Life date). If we bump to, e.g. macOS 11 we'd need to move where we build the x64 releases onto a macOS 11 machine (and probably would need to set up a x64 macOS 11 release machine unless we'd be comfortable compiling under Rosetta 2 on the arm64 machines (which we do anyway for the pkg builds)).

@UlisesGascon
Copy link
Member Author

Good! Let's discuss about it in the next meeting and build a plan 👍

@mhdawson
Copy link
Member

Moving to 11 as the minimum makes sense to me.

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Apr 11, 2023

As agreed in #3299 we will remove the MacOS 10.14 machines from the build pipelines. This open the opportunity to use the HW for other MacOS Versions. The deprecation will take place once Nodejs 14 reach the End-of-life at 2023-04-30.

Affected machines

  • orka-macos10.14-x64-1
  • orka-macos10.14-x64-2
  • orka-macos10.14-x64-3

Next steps (After 2023-04-30)

As only Orka VMs are affected we can do a backup and delete them easily:

I will need some help to remove the machines from Jenkins as I don't have the admin access to Jenkins. Should I ask for the access?

The empty slots that this machines will generate in Orka cluster will be managed in a separate discussion (#3240)

@UlisesGascon UlisesGascon changed the title MacOS 10.14 deprecation and HW reuse potential MacOS 10.14 deprecation plan Apr 11, 2023
@mhdawson
Copy link
Member

@UlisesGascon I'm happy to remove the machines from Jenkins. Are there other cases where you need jenkins access? If so then getting you access instead might make sense.

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Apr 11, 2023

@mhdawson I will need to add machines in the near future when we move ahead with #3240 🤔

@mhdawson
Copy link
Member

@nodejs/build I'm thinking giving @UlisesGascon Jenkins access makes sense. What do you think?

@targos
Copy link
Member

targos commented Apr 12, 2023

+1 from me

@richardlau
Copy link
Member

Also +1 from me.

@UlisesGascon
Copy link
Member Author

UlisesGascon commented May 1, 2023

Current Status

  • backups done. I replaced the previous backups (macos1014-x64-1_11012023, macos1014-x64-2_11012023 and macos1014-x64-3_11012023) with the new ones (macos1014-x64-1_01-may-2023, macos1014-x64-2_01-may-2023 and macos1014-x64-3_01-may-2023)
  • Orka 10.14 vms were purged.
  • Orka 10.14 machines were removed from Jenkins

Before

Captura de pantalla 2023-05-02 a las 0 20 33

Captura de pantalla 2023-05-02 a las 0 06 00

After

Captura de pantalla 2023-05-02 a las 0 20 21

Captura de pantalla 2023-05-02 a las 0 19 59

Next steps

This issue will be closed when:

@sxa
Copy link
Member

sxa commented May 15, 2023

@UlisesGascon Did we verify if building on the later release with the minimum deployment target option of 10.14/10.15 still allows it to run ok on those versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants